You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2017/12/16 01:48:52 UTC
[GitHub] activemq-artemis pull request #1713: fixing compatibility issues + testsuite...
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1713#discussion_r157330512
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java ---
@@ -752,15 +752,12 @@ public RoutingStatus route(final Message message,
Bindings bindings = addressManager.getBindingsForRoutingAddress(context.getAddress() == null ? message.getAddressSimpleString() : context.getAddress());
- // TODO auto-create queues here?
- // first check for the auto-queue creation thing
- if (bindings == null) {
- // There is no queue with this address, we will check if it needs to be created
- // if (queueCreator.create(address)) {
- // TODO: this is not working!!!!
- // reassign bindings if it was created
- // bindings = addressManager.getBindingsForRoutingAddress(address);
- // }
+ if (bindings == null && context.getAddress() != null) {
+ AddressSettings settings = server.getAddressSettingsRepository().getMatch(context.getAddress().toString());
+ if (settings.isAutoCreateQueues()) {
--- End diff --
@mtaylor Please review this.. this is fixing the compatibility between a 1.4 server and a 2.5 (snapshot) client.
---