You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/03/09 13:17:16 UTC

[GitHub] [logging-log4j2] rmannibucau opened a new pull request #473: ensure EncodingPatternConverter#handlesThrowable is implemented

rmannibucau opened a new pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473


   Giess the title is enough to understand what happens ;).
   Long story short the handlesThrowable() logic to skip forced (by default) append of the exception does not work as soon as encoding is used which is almost always the case when outputing JSON/XML using PatternFormatter (since Json appender required 3rd party libs which are often undesired).
   This PR implements this method by checking the nested formatters.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vy merged pull request #473: ensure EncodingPatternConverter#handlesThrowable is implemented

Posted by GitBox <gi...@apache.org>.
vy merged pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vy commented on pull request #473: ensure EncodingPatternConverter#handlesThrowable is implemented

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473#issuecomment-819366479


   Thanks for the contribution @rmannibucau! We had some discussion in the mailing list regarding the failing tests of this PR, though apparently we forgot about the ticket itself. :sweat_smile:
   
   I will fix `changes.xml` for you – try to update it next time, please. I will also try to back-port this to `release-2.x`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] rmannibucau commented on pull request #473: ensure EncodingPatternConverter#handlesThrowable is implemented

Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473#issuecomment-819338565


   up?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vy commented on pull request #473: ensure EncodingPatternConverter#handlesThrowable is implemented

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473#issuecomment-819368263


   One last remark, a JIRA ticket is always handy. It helps us to link changes with tickets. I will create one for you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vy commented on pull request #473: LOG4J2-3070 Ensure EncodingPatternConverter#handlesThrowable is implemented

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473#issuecomment-819370081


   > since Json appender required 3rd party libs which are often undesired
   
   `JsonTemplateLayout` doesn't require any 3rd party libs, FYI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org