You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/22 21:22:41 UTC

[jira] [Commented] (NIFI-3636) Session should not copy FlowFile Attribute Map when creating new FlowFile object unless attributes are changing

    [ https://issues.apache.org/jira/browse/NIFI-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937163#comment-15937163 ] 

ASF GitHub Bot commented on NIFI-3636:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/1612

    NIFI-3636: Lazily copy FlowFile Attributes Hash Map instead of doing …

    …so eagerly.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-3636

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1612
    
----
commit 3ff5301e68d5c3f77b27afc1bf7dcb3f015c3911
Author: Mark Payne <ma...@hotmail.com>
Date:   2017-03-22T21:21:51Z

    NIFI-3636: Lazily copy FlowFile Attributes Hash Map instead of doing so eagerly.

----


> Session should not copy FlowFile Attribute Map when creating new FlowFile object unless attributes are changing
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3636
>                 URL: https://issues.apache.org/jira/browse/NIFI-3636
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.2.0
>
>
> Currently, each time we create a new FlowFile object, we do so using StandardFlowFileRecord.Builder and then call fromFlowFile(FlowFile). This copies the attributes map of the given FlowFile. We should instead just set the member variable of the builder to point at the same Map object as the given FlowFile and keep a flag indicating whether or not this was done. If this is done, we must lazily copy the hash map before modifying it. Otherwise, we can point to the same Map object.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)