You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/01/06 06:44:11 UTC

Review Request 55251: Added `filterRoles` method to extract some logic from `_roles`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55251/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.


Bugs: MESOS-6855
    https://issues.apache.org/jira/browse/MESOS-6855


Repository: mesos


Description
-------

This method takes an ObjectApprover and computes role names to
return results for. The logic was part of `_roles()` and can be
reused by `getRoles()`.


Diffs
-----

  src/master/http.cpp 75dcd6199dbfcca6260baed49b838a45312bb667 
  src/master/master.hpp 57fc6e6f2995078df80f0aa52707727db802ede0 

Diff: https://reviews.apache.org/r/55251/diff/


Testing
-------


Thanks,

Jay Guo