You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/11 05:25:04 UTC
[jira] [Commented] (GEODE-231) Remove deprecated AttributesMutator.setCacheListener

    [ https://issues.apache.org/jira/browse/GEODE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005903#comment-16005903 ] 

ASF GitHub Bot commented on GEODE-231:
--------------------------------------

GitHub user shankarh opened a pull request:

    https://github.com/apache/geode/pull/507

    GEODE-231 :  Remove deprecated AttributesMutator.setCacheListener

    Removed AttributesMutator.setCacheListener from AttributesMutator interface and AbstractRegion.
    Modified tests to use addCacheListener/initCacheListener.
    Removed tests which are not valid for new APIs
    Changed references in java docs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shankarh/geode feature/GEODE-231

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #507
    
----
commit f54579be9530d4a1eeb444ad40934129cbc9709a
Author: Shankar <sh...@ampool.io>
Date:   2017-05-09T18:20:39Z

    GEODE-231: Remove deprecated AttributesMutator.setCacheListener
    
    Removed setCacheListener method from AttributesMutator and AbstractRegion.
    Changed tests to use either initCacheListeners or addCacheListener methods from AttributesMutator.

commit 31eae2a2b7933c7feea4d080721ee953768ce2f6
Author: Shankar <sh...@ampool.io>
Date:   2017-05-09T18:32:44Z

    GEODE-231: Remove deprecated AttributesMutator.setCacheListener
    
    Spotlessapply changes

commit 92cc47148b33a0e8bad9e85d62a397fae2e07f94
Author: Shankar <sh...@ampool.io>
Date:   2017-05-10T07:29:42Z

    GEODE-231: Remove deprecated AttributesMutator.setCacheListener
    
    Removed commented test

----


> Remove deprecated AttributesMutator.setCacheListener
> ----------------------------------------------------
>
>                 Key: GEODE-231
>                 URL: https://issues.apache.org/jira/browse/GEODE-231
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Darrel Schneider
>            Assignee: Shankar Hundekar
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> It looks like AttributesMutator.setCacheListener is currently only called from test code. All of these calls can be replaced with AttributesMutator.initCacheListeners with an array of one listener.
> It is probably not safe to use AttributesMutator.addCacheListener since it leaves an original listeners in place.
> The method is called in about 25 different tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)