You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/24 15:11:32 UTC

[GitHub] [airflow] SamWheating commented on a change in pull request #14981: Allow override of project_id in DataprocJobBaseOperator

SamWheating commented on a change in pull request #14981:
URL: https://github.com/apache/airflow/pull/14981#discussion_r600576366



##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -943,9 +947,8 @@ def __init__(
 
         self.job_error_states = job_error_states if job_error_states is not None else {'ERROR'}
         self.impersonation_chain = impersonation_chain
-
         self.hook = DataprocHook(gcp_conn_id=gcp_conn_id, impersonation_chain=impersonation_chain)

Review comment:
       Thats a really good point, but we won't be able to get the project_id from the hook if the hook is not yet instantiated 🤔 We would also have to update the generate_job function in all of the operators which inherit from this one. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org