You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tsuyoshi Ozawa (JIRA)" <ji...@apache.org> on 2016/07/12 04:45:11 UTC
[jira] [Comment Edited] (HADOOP-11361) Fix a race condition in
MetricsSourceAdapter.updateJmxCache
[ https://issues.apache.org/jira/browse/HADOOP-11361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372166#comment-15372166 ]
Tsuyoshi Ozawa edited comment on HADOOP-11361 at 7/12/16 4:44 AM:
------------------------------------------------------------------
[~yzhangal] +1 for the idea. It avoid the deadlock between MetricsSystemImpl's lock and MetricsSourceAdapter's lock
{{getMetricsPart1}} should be named as {{getMetrics}}(), and {{getMetricsPart2}} should be renamed as {{updateAndGetLastRecs}}, since it's more straightforward. Could you update the patch?
[~brahmareddy] [~vinayrpet] could you review [~yzhangal]'s patch if you have time? I would like to double-check new patch if possible.
was (Author: ozawa):
[~yzhangal] +1 for the idea. It avoid the deadlock between MetricsSystemImpl's lock and MetricsSourceAdapter's lock
{{getMetricsPart1}} should be named as {{getMetrics}}(), and {{getMetricsPart2}} should be renamed as {{updateAndGetLastRecs}}, since it's more straightforward. Could you update the patch?
> Fix a race condition in MetricsSourceAdapter.updateJmxCache
> -----------------------------------------------------------
>
> Key: HADOOP-11361
> URL: https://issues.apache.org/jira/browse/HADOOP-11361
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.4.1, 2.5.1, 2.6.0
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-111361-003.patch, HADOOP-11361-002.patch, HADOOP-11361-004.patch, HADOOP-11361.patch, HDFS-7487.patch
>
>
> {noformat}
> Caused by: java.lang.NullPointerException
> at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateAttrCache(MetricsSourceAdapter.java:247)
> at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:177)
> at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getAttribute(MetricsSourceAdapter.java:102)
> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:647)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org