You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/12/30 23:57:43 UTC
Review Request 55106: GEODE-1580 ci failure:
GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithDLock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55106/
-----------------------------------------------------------
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
Bugs: GEODE-1580
https://issues.apache.org/jira/browse/GEODE-1580
Repository: geode
Description
-------
Added a dunit blackboard to coordinate creation of a deadlock with the DistributedLockService. Removed pauses and added use of Awaitility to wait for conditions.
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java 872016bdcfb564e9a30f54f416b6770599246dce
geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 17ec800517066b1a7564a91be10c7d659f24a8fb
geode-core/src/test/java/org/apache/geode/test/dunit/DUnitBlackboard.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/DUnitBlackboardImpl.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java ebbb2fd5fffd5b4e1120a05c5103698b6be9e1f5
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 7a9d7f00ff2efcdb811217c5dd42baeebe862685
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java 5a80a64f82ad0d7ed6e22c06e006e82d7d1e9d95
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 7852db5e01f14196777fabc4003295c26a61ef0f
Diff: https://reviews.apache.org/r/55106/diff/
Testing
-------
Running precheckin since some dunit infrastructure was modified
Thanks,
Bruce Schuchardt
Re: Review Request 55106: GEODE-1580 ci failure:
GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithDLock
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55106/#review160435
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On Jan. 3, 2017, 6:03 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55106/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 6:03 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1580
> https://issues.apache.org/jira/browse/GEODE-1580
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added a dunit blackboard to coordinate creation of a deadlock with the DistributedLockService. Removed pauses and added use of Awaitility to wait for conditions.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 17ec800517066b1a7564a91be10c7d659f24a8fb
> geode-core/src/test/java/org/apache/geode/test/dunit/DUnitBlackboard.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/DUnitBlackboardDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/InternalBlackboard.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/InternalBlackboardImpl.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java ebbb2fd5fffd5b4e1120a05c5103698b6be9e1f5
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 7a9d7f00ff2efcdb811217c5dd42baeebe862685
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java 5a80a64f82ad0d7ed6e22c06e006e82d7d1e9d95
>
> Diff: https://reviews.apache.org/r/55106/diff/
>
>
> Testing
> -------
>
> Running precheckin since some dunit infrastructure was modified
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 55106: GEODE-1580 ci failure:
GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithDLock
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55106/#review160434
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Jan. 3, 2017, 6:03 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55106/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 6:03 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1580
> https://issues.apache.org/jira/browse/GEODE-1580
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added a dunit blackboard to coordinate creation of a deadlock with the DistributedLockService. Removed pauses and added use of Awaitility to wait for conditions.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 17ec800517066b1a7564a91be10c7d659f24a8fb
> geode-core/src/test/java/org/apache/geode/test/dunit/DUnitBlackboard.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/DUnitBlackboardDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/InternalBlackboard.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/InternalBlackboardImpl.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java ebbb2fd5fffd5b4e1120a05c5103698b6be9e1f5
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 7a9d7f00ff2efcdb811217c5dd42baeebe862685
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java 5a80a64f82ad0d7ed6e22c06e006e82d7d1e9d95
>
> Diff: https://reviews.apache.org/r/55106/diff/
>
>
> Testing
> -------
>
> Running precheckin since some dunit infrastructure was modified
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 55106: GEODE-1580 ci failure:
GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithDLock
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55106/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 6:03 p.m.)
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
Changes
-------
I've moved RMI blackboard to internal package. Unit tests now interact with it using a non-RMI object, removing the need to catch RemoteException.
I also added unit tests for the blackboard, which exposed a problem in waitForGate().
Bugs: GEODE-1580
https://issues.apache.org/jira/browse/GEODE-1580
Repository: geode
Description
-------
Added a dunit blackboard to coordinate creation of a deadlock with the DistributedLockService. Removed pauses and added use of Awaitility to wait for conditions.
Diffs (updated)
-----
geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 17ec800517066b1a7564a91be10c7d659f24a8fb
geode-core/src/test/java/org/apache/geode/test/dunit/DUnitBlackboard.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/internal/DUnitBlackboardDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/internal/InternalBlackboard.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/internal/InternalBlackboardImpl.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java ebbb2fd5fffd5b4e1120a05c5103698b6be9e1f5
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 7a9d7f00ff2efcdb811217c5dd42baeebe862685
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java 5a80a64f82ad0d7ed6e22c06e006e82d7d1e9d95
Diff: https://reviews.apache.org/r/55106/diff/
Testing
-------
Running precheckin since some dunit infrastructure was modified
Thanks,
Bruce Schuchardt