You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Jesus Camacho Rodriguez <jc...@hortonworks.com> on 2015/11/06 16:44:51 UTC
[VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Hi all,
I have created a build for Apache Calcite 1.5.0, release candidate 0.
This is our first release as a top-level Apache project! Thanks to everyone who has contributed to it.
You can read the release notes here:
https://github.com/jcamachor/calcite/tree/branch-1.5/site/_docs/history.md
The commit to be voted upon:
https://github.com/jcamachor/calcite/commit/ba6e43c6983ca92d8ce32a693776dbe73f19e0dc
Its hash is ba6e43c6983ca92d8ce32a693776dbe73f19e0dc.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.5.0-rc0/
The hashes of the artifacts are as follows:
src.tar.gz.md5 f76cc6ce08721102753732a75ab79192
src.tar.gz.sha1 a1344ee8727d9f4d9df3fda7eaa7179ad9788b39
src.zip.md5 10bc39a8e0a42646431f77f35c6cc3e4
src.zip.sha1 cb345c7d2afdc0f5ba86504483ac378e827fa996
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1010
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/jcamacho.asc
Please vote on releasing this package as Apache Calcite 1.5.0.
The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.5.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Jesús
Re: [VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Posted by Josh Elser <el...@apache.org>.
Julian Hyde wrote:
>> On Nov 6, 2015, at 9:00 PM, Josh Elser<el...@apache.org> wrote:
>>
>> Only minor nit I noticed was that in https://repository.apache.org/content/repositories/orgapachecalcite-1010/org/apache/calcite/calcite/1.5.0/, the files are named "calcite.." and not "apache-calcite…".
>
> For those artifacts, which will be deployed to maven central on release, I’m pretty sure that “calcite-xxx” is the correct name, not “apache-calcite-xxx”. The names of those files match the maven artifact names. E.g. core has groupId: “org.apache.calcite”, name: “calcite-core”. It lives in the directory org/apache/calcite/calcite-core so does not need to be fully-qualified.
>
> Julian
>
My nit was only for that specific directory (the tarball and zip). This
also matches what Jesús deployed to dist.a.o too. I agree with you
entirely for the jars, but feel like apache-foo is appropriate for the
source-archives.
Re: [VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
> On Nov 6, 2015, at 9:00 PM, Josh Elser <el...@apache.org> wrote:
>
> Only minor nit I noticed was that in https://repository.apache.org/content/repositories/orgapachecalcite-1010/org/apache/calcite/calcite/1.5.0/, the files are named "calcite.." and not "apache-calcite…".
For those artifacts, which will be deployed to maven central on release, I’m pretty sure that “calcite-xxx” is the correct name, not “apache-calcite-xxx”. The names of those files match the maven artifact names. E.g. core has groupId: “org.apache.calcite”, name: “calcite-core”. It lives in the directory org/apache/calcite/calcite-core so does not need to be fully-qualified.
Julian
Re: [VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Posted by Josh Elser <el...@apache.org>.
+1 (non-binding)
Thanks for making the RC, Jesús!
Only minor nit I noticed was that in
https://repository.apache.org/content/repositories/orgapachecalcite-1010/org/apache/calcite/calcite/1.5.0/,
the files are named "calcite.." and not "apache-calcite...".
* Verified sigs/xsums
* Checked LICENSE/NOTICE
* Built from source and successfully ran all (Maven) tests
* Built from tarball/zip
* Verified `mvn site`
* Read through release notes (spell-check/grammar)
Jesus Camacho Rodriguez wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.5.0, release candidate 0.
>
> This is our first release as a top-level Apache project! Thanks to everyone who has contributed to it.
>
> You can read the release notes here:
> https://github.com/jcamachor/calcite/tree/branch-1.5/site/_docs/history.md
>
> The commit to be voted upon:
> https://github.com/jcamachor/calcite/commit/ba6e43c6983ca92d8ce32a693776dbe73f19e0dc
>
> Its hash is ba6e43c6983ca92d8ce32a693776dbe73f19e0dc.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.5.0-rc0/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 f76cc6ce08721102753732a75ab79192
> src.tar.gz.sha1 a1344ee8727d9f4d9df3fda7eaa7179ad9788b39
> src.zip.md5 10bc39a8e0a42646431f77f35c6cc3e4
> src.zip.sha1 cb345c7d2afdc0f5ba86504483ac378e827fa996
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1010
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jcamacho.asc
>
> Please vote on releasing this package as Apache Calcite 1.5.0.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.5.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Jesús
>
>
Re: [VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Posted by Jinfeng Ni <ji...@gmail.com>.
+1
Downloaded apache-calcite-1.5.0-src.tar.gz. Did a full build. Checked
checksums for both .tar.gz and .zip files.
On Sun, Nov 8, 2015 at 10:11 PM, Vladimir Sitnikov
<si...@gmail.com> wrote:
> +1
> Built from git, tested, tested staged Maven repository.
>
> Vladimir
Re: [VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Posted by Vladimir Sitnikov <si...@gmail.com>.
+1
Built from git, tested, tested staged Maven repository.
Vladimir
Re: [VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Posted by Aman Sinha <am...@apache.org>.
+1
Downloaded apache-calcite-1.5.0-src.tar.gz, built on my Mac, ran unit tests
successfully. My Java version: 1.7.0_45.
Did sanity checks for various files including README. Ran a find command
to make sure no generated code was included in the source.
Aman
On Sun, Nov 8, 2015 at 9:48 PM, Jacques Nadeau <ja...@apache.org> wrote:
> Downloaded, extracted, built & tested tarball.
>
> Downloaded sources and javadoc maven artifacts and verified inclusion of
> appropriate files. Navigated exploded javadoc via browser.
>
> Reviewed release notes (nicely organized)
>
> Nice, meaty release with a great combination of contributions.
>
> +1 binding
>
>
> On Fri, Nov 6, 2015 at 7:44 AM, Jesus Camacho Rodriguez <
> jcamachorodriguez@hortonworks.com> wrote:
>
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.5.0, release candidate 0.
> >
> > This is our first release as a top-level Apache project! Thanks to
> > everyone who has contributed to it.
> >
> > You can read the release notes here:
> >
> https://github.com/jcamachor/calcite/tree/branch-1.5/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> >
> https://github.com/jcamachor/calcite/commit/ba6e43c6983ca92d8ce32a693776dbe73f19e0dc
> >
> > Its hash is ba6e43c6983ca92d8ce32a693776dbe73f19e0dc.
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.5.0-rc0/
> >
> > The hashes of the artifacts are as follows:
> > src.tar.gz.md5 f76cc6ce08721102753732a75ab79192
> > src.tar.gz.sha1 a1344ee8727d9f4d9df3fda7eaa7179ad9788b39
> > src.zip.md5 10bc39a8e0a42646431f77f35c6cc3e4
> > src.zip.sha1 cb345c7d2afdc0f5ba86504483ac378e827fa996
> >
> > A staged Maven repository is available for review at:
> > https://repository.apache.org/content/repositories/orgapachecalcite-1010
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/jcamacho.asc
> >
> > Please vote on releasing this package as Apache Calcite 1.5.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of
> > at least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.5.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Jesús
> >
> >
> >
>
Re: [VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Posted by Jacques Nadeau <ja...@apache.org>.
Downloaded, extracted, built & tested tarball.
Downloaded sources and javadoc maven artifacts and verified inclusion of
appropriate files. Navigated exploded javadoc via browser.
Reviewed release notes (nicely organized)
Nice, meaty release with a great combination of contributions.
+1 binding
On Fri, Nov 6, 2015 at 7:44 AM, Jesus Camacho Rodriguez <
jcamachorodriguez@hortonworks.com> wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.5.0, release candidate 0.
>
> This is our first release as a top-level Apache project! Thanks to
> everyone who has contributed to it.
>
> You can read the release notes here:
> https://github.com/jcamachor/calcite/tree/branch-1.5/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://github.com/jcamachor/calcite/commit/ba6e43c6983ca92d8ce32a693776dbe73f19e0dc
>
> Its hash is ba6e43c6983ca92d8ce32a693776dbe73f19e0dc.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.5.0-rc0/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 f76cc6ce08721102753732a75ab79192
> src.tar.gz.sha1 a1344ee8727d9f4d9df3fda7eaa7179ad9788b39
> src.zip.md5 10bc39a8e0a42646431f77f35c6cc3e4
> src.zip.sha1 cb345c7d2afdc0f5ba86504483ac378e827fa996
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1010
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jcamacho.asc
>
> Please vote on releasing this package as Apache Calcite 1.5.0.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.5.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Jesús
>
>
>
Re: [VOTE] Release apache-calcite-1.5.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Checked hashes, license, notice, ran rat, built and tested on mac os/jdk 1.8. (I built and ran the test suite on windows 2 commits ago.)
Looks good!
+1 (binding)
Minor nit: git.properties in the src.tar.gz contains "git.commit.id.abbrev=8336bc0”, the parent of the true commit id, ba6e43c. (I expect this is due to running maven in local mode.)
Julian
> On Nov 6, 2015, at 7:44 AM, Jesus Camacho Rodriguez <jc...@hortonworks.com> wrote:
>
> Hi all,
>
> I have created a build for Apache Calcite 1.5.0, release candidate 0.
>
> This is our first release as a top-level Apache project! Thanks to everyone who has contributed to it.
>
> You can read the release notes here:
> https://github.com/jcamachor/calcite/tree/branch-1.5/site/_docs/history.md
>
> The commit to be voted upon:
> https://github.com/jcamachor/calcite/commit/ba6e43c6983ca92d8ce32a693776dbe73f19e0dc
>
> Its hash is ba6e43c6983ca92d8ce32a693776dbe73f19e0dc.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.5.0-rc0/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 f76cc6ce08721102753732a75ab79192
> src.tar.gz.sha1 a1344ee8727d9f4d9df3fda7eaa7179ad9788b39
> src.zip.md5 10bc39a8e0a42646431f77f35c6cc3e4
> src.zip.sha1 cb345c7d2afdc0f5ba86504483ac378e827fa996
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1010
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jcamacho.asc
>
> Please vote on releasing this package as Apache Calcite 1.5.0.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.5.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Jesús
>
>