You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2017/09/09 00:27:20 UTC
[Impala-ASF-CR] IMPALA-4082: Remove todo item in getRegionsInRange
Tianyi Wang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8018
Change subject: IMPALA-4082: Remove todo item in getRegionsInRange
......................................................................
IMPALA-4082: Remove todo item in getRegionsInRange
HbaseTable.GetRegionsInRange is a function copied and modified from
HTable in Hbase 0.95.1 or ealier. The HTable function uses cached region
location and the modified version gets more up-to-date information.
There is a todo item for the removal of this modified function if
Hbase provides the same functionality itself. In Hbase 0.95.2, the
HTable function is renamed to getKeysAndRegionsInRange and in Hbase
0.99 it became a private function. Thus this todo item is no longer
needed and is removed by this patch.
Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a
---
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/8018/1
--
To view, visit http://gerrit.cloudera.org:8080/8018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-4082: Remove todo item in getRegionsInRange
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4082: Remove todo item in getRegionsInRange
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4082: Remove todo item in getRegionsInRange
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4082: Remove todo item in getRegionsInRange
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4082: Remove todo item in getRegionsInRange
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4082: Remove todo item in getRegionsInRange
......................................................................
IMPALA-4082: Remove todo item in getRegionsInRange
HbaseTable.GetRegionsInRange is a function copied and modified from
HTable in Hbase 0.95.1 or ealier. The HTable function uses cached region
location and the modified version gets more up-to-date information.
There is a todo item for the removal of this modified function if
Hbase provides the same functionality itself. In Hbase 0.95.2, the
HTable function is renamed to getKeysAndRegionsInRange and in Hbase
0.99 it became a private function. Thus this todo item is no longer
needed and is removed by this patch.
Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a
Reviewed-on: http://gerrit.cloudera.org:8080/8018
Reviewed-by: Lars Volker <lv...@cloudera.com>
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Lars Volker: Looks good to me, but someone else must approve
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-4082: Remove todo item in getRegionsInRange
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4082: Remove todo item in getRegionsInRange
......................................................................
Patch Set 1: Code-Review+1
Thank you for fixing this.
--
To view, visit http://gerrit.cloudera.org:8080/8018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4082: Remove todo item in getRegionsInRange
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4082: Remove todo item in getRegionsInRange
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1213/
--
To view, visit http://gerrit.cloudera.org:8080/8018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No