You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/06 07:43:37 UTC

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1760: move scalar value to datafusion-common

Jimexist opened a new pull request #1760:
URL: https://github.com/apache/arrow-datafusion/pull/1760


   # Which issue does this PR close?
   
   - Closes #1752 
   - Part of #1750 
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Jimexist merged pull request #1760: [split/4] move scalar value to datafusion-common

Posted by GitBox <gi...@apache.org>.
Jimexist merged pull request #1760:
URL: https://github.com/apache/arrow-datafusion/pull/1760


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Jimexist commented on pull request #1760: [split/4] move scalar value to datafusion-common

Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #1760:
URL: https://github.com/apache/arrow-datafusion/pull/1760#issuecomment-1031590202


   > `ScalarValue` would be a very reasonable candidate for its own subcrate (especially if the idea is to eventually move it upstream into arrow or elsewhere)
   
   i think for now common is fine. if really needed can spin out to be datafusion-scalar and then have common depend on that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #1760: [split/4] move scalar value to datafusion-common

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1760:
URL: https://github.com/apache/arrow-datafusion/pull/1760#issuecomment-1031592524


   > i think for now common is fine. if really needed can spin out to be datafusion-scalar and then have common depend on that.
   
   
   Makes sense to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org