You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by "fishy (via GitHub)" <gi...@apache.org> on 2023/04/07 19:30:21 UTC

[GitHub] [thrift] fishy commented on pull request #2776: THRIFT-5697: Use 32 bit ints for generated go enums

fishy commented on PR #2776:
URL: https://github.com/apache/thrift/pull/2776#issuecomment-1500577465

   > I know this isn't spec compliant, but changing it would be a big BC break. I'm leaning towards no.
   > 
   > cc @fishy
   
   yea I plan to assess how breaking this is. not changing it only has very minimal impact (the only thing that could go wrong is someone try to use a value outside of i32 range, which would be very rare).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org