You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/01/19 02:54:29 UTC
[GitHub] [trafficserver] bneradt opened a new pull request #8617: TSHttpTxnCacheLookupStatusGet: call need_to_revalidate
bneradt opened a new pull request #8617:
URL: https://github.com/apache/trafficserver/pull/8617
This reverts #8548 and instead directly calls
HttpTransact::need_to_revalidate in TSHttpTxnCacheLookupStatusGet to
ensure that an object which is a cache hit is indeed something ATS can
return to the client.
Fixes #8616
---
## For Review:
This fixes the cache-request-method.test.py AuTest which is currently failing CI for master. Most of this change simply reverts #8548. The only real change is calling need_to_revalidate in InkAPI.cc in TSHttpTxnCacheLookupStatusGet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8617: TSHttpTxnCacheLookupStatusGet: call need_to_revalidate
Posted by GitBox <gi...@apache.org>.
bneradt merged pull request #8617:
URL: https://github.com/apache/trafficserver/pull/8617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8617: TSHttpTxnCacheLookupStatusGet: call need_to_revalidate
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8617:
URL: https://github.com/apache/trafficserver/pull/8617#issuecomment-1021595729
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8617: TSHttpTxnCacheLookupStatusGet: call need_to_revalidate
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8617:
URL: https://github.com/apache/trafficserver/pull/8617#issuecomment-1016041968
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8617: TSHttpTxnCacheLookupStatusGet: call need_to_revalidate
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8617:
URL: https://github.com/apache/trafficserver/pull/8617#issuecomment-1016071345
/cc @serrislew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8617: TSHttpTxnCacheLookupStatusGet: call need_to_revalidate
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8617:
URL: https://github.com/apache/trafficserver/pull/8617#issuecomment-1026204126
Adding the 9.2.x project as this will be reverted in 9.2.x when this is cherry-picked back:
https://github.com/apache/trafficserver/pull/8637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8617: TSHttpTxnCacheLookupStatusGet: call need_to_revalidate
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8617:
URL: https://github.com/apache/trafficserver/pull/8617#issuecomment-1016037623
[approve ci debian]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org