You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2022/08/23 19:56:01 UTC
[GitHub] [qpid-proton-j] BenD10 opened a new pull request, #43: PROTON-2347 Prevent leak when IOException is encountered
BenD10 opened a new pull request, #43:
URL: https://github.com/apache/qpid-proton-j/pull/43
https://issues.apache.org/jira/browse/PROTON-2347
When an IOException is thrown, the SocketChannel was not properly
cleaned up which caused a file descriptor leak.
To confirm the fix, I used the reproducer available in the above JIRA and monitored open file handles.
Using 0.33.10:
```
ben@ubuntu:~$ date && lsof -p 34755 | wc -l
Tue 23 Aug 2022 03:24:14 PM EDT
60086
ben@ubuntu:~$ date && lsof -p 34755 | wc -l
Tue 23 Aug 2022 03:24:17 PM EDT
85005
ben@ubuntu:~$ date && lsof -p 34755 | wc -l
Tue 23 Aug 2022 03:24:21 PM EDT
116822
ben@ubuntu:~$ date && lsof -p 34755 | wc -l
Tue 23 Aug 2022 03:24:27 PM EDT
155766
ben@ubuntu:~$ date && lsof -p 34755 | wc -l
Tue 23 Aug 2022 03:24:33 PM EDT
209201
ben@ubuntu:~$ date && lsof -p 34755 | wc -l
Tue 23 Aug 2022 03:24:41 PM EDT
275748
```
With the fix on 0.34.0-SNAPSHOT
```
ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l
Tue 23 Aug 2022 03:40:23 PM EDT
44
ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l
Tue 23 Aug 2022 03:40:26 PM EDT
40
ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l
Tue 23 Aug 2022 03:40:32 PM EDT
44
ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l
Tue 23 Aug 2022 03:40:47 PM EDT
44
ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l
Tue 23 Aug 2022 03:40:54 PM EDT
44
ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l
Tue 23 Aug 2022 03:41:01 PM EDT
44
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] gemmellr commented on pull request #43: PROTON-2347 Prevent leak when IOException is encountered
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #43:
URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1225918692
The reactor free() looks wrong since it may have other connections. There was another related change in #38 other folks already seem to be using, I have applied it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] BenD10 commented on pull request #43: PROTON-2347 Prevent leak when IOException is encountered
Posted by GitBox <gi...@apache.org>.
BenD10 commented on PR #43:
URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1226036217
Awesome I can see it main now, thank you very much @gemmellr!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] gemmellr commented on pull request #43: PROTON-2347 Prevent leak when IOException is encountered
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #43:
URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1230083642
Theres some other general updates I'll do before releasing, probably late this week or next week (release process takes at least a few days). Note it will be with the other change referenced, not this one, per previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] BenD10 closed pull request #43: PROTON-2347 Prevent leak when IOException is encountered
Posted by GitBox <gi...@apache.org>.
BenD10 closed pull request #43: PROTON-2347 Prevent leak when IOException is encountered
URL: https://github.com/apache/qpid-proton-j/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] BenD10 commented on pull request #43: PROTON-2347 Prevent leak when IOException is encountered
Posted by GitBox <gi...@apache.org>.
BenD10 commented on PR #43:
URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1224830720
Hi @gemmellr, I'm hopeful you can take a look at this whenever you have a chance. Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] RamIoTMalhotra commented on pull request #43: PROTON-2347 Prevent leak when IOException is encountered
Posted by GitBox <gi...@apache.org>.
RamIoTMalhotra commented on PR #43:
URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1228884085
@gemmellr when can we expect a release for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org