You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/07 00:22:18 UTC

[GitHub] [commons-numbers] darkma773r commented on pull request #92: NUMBERS-156: replacing SafeNorm with Norms and Summation

darkma773r commented on pull request #92:
URL: https://github.com/apache/commons-numbers/pull/92#issuecomment-855490951


   @aherbert, thanks for the thorough review! I've implemented the changes you requested except as noted in the comments. Coveralls is still failing, even on JDK 11. There does not appear to be a later version to upgrade to, unfortunately. Let me know if any other changes need to be made.
   
   Note that I also added an exception to the spotbugs exclude file for the new floating point equality expression in Angle.Normalization. The build was failing otherwise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org