You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/09/23 21:09:08 UTC
Review Request 38684: Made the mount in the bind mount backend a
shared mount.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38684/
-----------------------------------------------------------
Review request for mesos, Timothy Chen and Jiang Yan Xu.
Repository: mesos
Description
-------
Made the mount in the bind mount backend a shared mount.
Diffs
-----
src/slave/containerizer/provisioner/backends/bind.cpp 5cd83a60ba9a6cef7de07add9a141755d4762786
Diff: https://reviews.apache.org/r/38684/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 38684: Made the mount in the bind mount backend a
shared mount.
Posted by Jie Yu <yu...@gmail.com>.
> On Sept. 23, 2015, 7:58 p.m., Jiang Yan Xu wrote:
> > Ship It!
Created https://issues.apache.org/jira/browse/MESOS-3503 to track the work of creating integration tests.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38684/#review100270
-----------------------------------------------------------
On Sept. 23, 2015, 7:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38684/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 7:09 p.m.)
>
>
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the mount in the bind mount backend a shared mount.
>
> This is because we made slave's work_dir a shared mount.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/backends/bind.cpp 5cd83a60ba9a6cef7de07add9a141755d4762786
>
> Diff: https://reviews.apache.org/r/38684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 38684: Made the mount in the bind mount backend a
shared mount.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38684/#review100270
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Sept. 23, 2015, 12:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38684/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 12:09 p.m.)
>
>
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the mount in the bind mount backend a shared mount.
>
> This is because we made slave's work_dir a shared mount.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/backends/bind.cpp 5cd83a60ba9a6cef7de07add9a141755d4762786
>
> Diff: https://reviews.apache.org/r/38684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 38684: Made the mount in the bind mount backend a
shared mount.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38684/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 7:09 p.m.)
Review request for mesos, Timothy Chen and Jiang Yan Xu.
Repository: mesos
Description (updated)
-------
Made the mount in the bind mount backend a shared mount.
This is because we made slave's work_dir a shared mount.
Diffs
-----
src/slave/containerizer/provisioner/backends/bind.cpp 5cd83a60ba9a6cef7de07add9a141755d4762786
Diff: https://reviews.apache.org/r/38684/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu