You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2025/11/21 20:01:22 UTC

[PR] Enable multiview for XJB (JAXB customization files) [netbeans]

matthiasblaesing opened a new pull request, #9030:
URL: https://github.com/apache/netbeans/pull/9030

   Closes: #9008


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Enable multiview for XJB (JAXB customization files) [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #9030:
URL: https://github.com/apache/netbeans/pull/9030#discussion_r2554190545


##########
java/xml.jaxb/nbproject/project.xml:
##########
@@ -61,6 +61,23 @@
                         <specification-version>1.40</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.netbeans.api.progress.nb</code-name-base>

Review Comment:
   well, now you removed it completely which is ok too I suppose ;)
   
   what I tried to explain is that `org.netbeans.api.progress.nb` could be changed to `org.netbeans.api.progress` which was introduced as smaller API since https://github.com/emilianbold/netbeans-releases/commit/e7049cf98094ee5f0b7dea02c0c0e43e01e8da98



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Enable multiview for XJB (JAXB customization files) [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #9030:
URL: https://github.com/apache/netbeans/pull/9030#discussion_r2553817719


##########
java/xml.jaxb/nbproject/project.xml:
##########
@@ -61,6 +61,23 @@
                         <specification-version>1.40</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.netbeans.api.progress.nb</code-name-base>

Review Comment:
   ah I see. If I understood it correctly, there was an attempt to reduce the surface area of that API and split it in two (pre-apache, see linked commit in https://github.com/apache/netbeans/pull/8927).
   
   `org.netbeans.api.progress` would be the minimal/toolkit independent API. If I see this correctly it would be sufficient for this module since it uses only `ProgressHandle` and nothing more advanced. I likely forgot to add it as direct dependency to this module since I had to fix some manually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Enable multiview for XJB (JAXB customization files) [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #9030:
URL: https://github.com/apache/netbeans/pull/9030#discussion_r2553819630


##########
java/xml.jaxb/nbproject/project.xml:
##########
@@ -61,6 +61,23 @@
                         <specification-version>1.40</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.netbeans.api.progress.nb</code-name-base>

Review Comment:
   (its already a test dependency of `xml.jaxb`, which can be removed once its a compile dependency)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Enable multiview for XJB (JAXB customization files) [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #9030:
URL: https://github.com/apache/netbeans/pull/9030#discussion_r2551575109


##########
java/xml.jaxb/nbproject/project.xml:
##########
@@ -61,6 +61,23 @@
                         <specification-version>1.40</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.netbeans.api.progress.nb</code-name-base>

Review Comment:
   is there a reason for adding `progress.nb`? I think all it uses is `ProgressHandle` which is `org.netbeans.api.progress`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Enable multiview for XJB (JAXB customization files) [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #9030:
URL: https://github.com/apache/netbeans/pull/9030#discussion_r2552314594


##########
java/xml.jaxb/nbproject/project.xml:
##########
@@ -61,6 +61,23 @@
                         <specification-version>1.40</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.netbeans.api.progress.nb</code-name-base>

Review Comment:
   I used the "search for dependency" feature. Might have added that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Enable multiview for XJB (JAXB customization files) [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #9030:
URL: https://github.com/apache/netbeans/pull/9030#discussion_r2553937825


##########
java/xml.jaxb/nbproject/project.xml:
##########
@@ -61,6 +61,23 @@
                         <specification-version>1.40</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.netbeans.api.progress.nb</code-name-base>

Review Comment:
   Updated in place. I don't plan to do another round.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Enable multiview for XJB (JAXB customization files) [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #9030:
URL: https://github.com/apache/netbeans/pull/9030


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists