You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/02 20:50:48 UTC

[GitHub] [commons-configuration] arturobernalg edited a comment on pull request #91: Minor Improvements

arturobernalg edited a comment on pull request #91:
URL: https://github.com/apache/commons-configuration/pull/91#issuecomment-753527406


   Hi @garydgregory 
   
   I agree that I should have checked if the binaries was broken. My mistake by not running `mvn clean install japicmp:cmp`
   I've execute  `japicmp:cmp` and i notice that  are several error, including the two of the UPPERCASE that you comment.
   What do you think we should do? we solve all the error of CheckStyle in this PR  or do we create a new one? 
   
   [WARNING] checkstyle:check violations detected but failOnViolation set to false
   [INFO] You have 82 Checkstyle violations.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org