You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/25 08:21:17 UTC

[GitHub] [rocketmq-connect] odbozhou commented on a diff in pull request #259: [ISSUE #255]Standardize configuration and update documentation

odbozhou commented on code in PR #259:
URL: https://github.com/apache/rocketmq-connect/pull/259#discussion_r954651555


##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerConnector.java:
##########
@@ -263,6 +264,10 @@ void doShutdown() {
 
     /**
      * Wait for this connector to finish shutting down.
+<<<<<<< HEAD

Review Comment:
   fix conflict



##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerConnector.java:
##########
@@ -331,6 +336,10 @@ private void doTransitionTo(TargetState targetState) throws Throwable {
 
     /**
      * reconfigure
+<<<<<<< HEAD

Review Comment:
   fix conflict



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org