You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Lennart Jorelid (JIRA)" <ji...@codehaus.org> on 2013/04/29 11:37:53 UTC

[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of "../"

    [ https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=324384#comment-324384 ] 

Lennart Jorelid commented on MSITE-669:
---------------------------------------

Hello again, Herve and Lukas.

Just a friendly reminder that this bug/patch/misconception is a real pain for at least 3 projects within which I am working.
Neither of these projects can use released versions of the m-s-p to generate staged documentation.

Basically, this bug boils down to Maven's assumption that POMs always plays two roles (reactor and parent), whereas there are 
many good reasons to let some POMs be only reactor POMs (defining the reactor build order) and other POMs only parent 
POMs (defining mainly plugins, configuration and versions). This is particularly apparent when your build reactor contains
stereotype projects (such as projects defining entities), having a set of common needs/properties/build definitions but being
scattered in several places over the build reactor. This concept clashes with the way that the m-s-p defines its staging and
site generation. 

Have you had any chance to do a review of the patch I supplied in february?
Is anyone else involved in reviewing this [concept and patch], in case you don't have the cycles yourself?
As far as I have been able to tell, no feedback other than the comments on the MSITE-669 issue have been given. Am I missing something here?
                
> site:stage creates incorrect structure when module paths contains sets of "../"
> -------------------------------------------------------------------------------
>
>                 Key: MSITE-669
>                 URL: https://jira.codehaus.org/browse/MSITE-669
>             Project: Maven 2.x and 3.x Site Plugin
>          Issue Type: Bug
>          Components: multi module, relative links, site:stage(-deploy)
>    Affects Versions: 3.1, 3.2
>            Reporter: Lennart Jorelid
>            Assignee: Lukas Theussl
>         Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch, msite_669_v4.patch, nazgul_tools_project_dependencies.png, nazgul_tools_project_dependencies.png, nazgul_tools_reactor_structure.png, sample.zip
>
>
> Given the module definitions given below, the site:stage goal produces sets of maps relative to the staging directory - i.e. outside of the target directory.
> {code:xml} 
> <modules>
>   <module>../../validation/validation-api</module>
>   <module>../../validation/validation-aspect</module>
>   <module>../parent</module>
> </modules>
> {code}
> The staged site should be fully included within the staging directory. It would appear that relativization of links for site:stage should take special links into consideration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira