You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/21 05:48:09 UTC

[GitHub] TisonKun opened a new pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

TisonKun opened a new pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener
URL: https://github.com/apache/flink/pull/6729
 
 
   ## What is the purpose of the change
   
   After a discussion [here](https://github.com/apache/flink/commit/0735b5b935b0c0757943e2d58047afcfb9949560#commitcomment-30584257) with @tillrohrmann . I start to analyze the usage of `ActorGatewayTaskExecutionStateListener` and `TaskExecutionStateListener`.
   
   In conclusion, we abort `TaskExecutionStateListener` strategy and no any component rely on it. Instead, we introduce `TaskManagerActions` to take the role for the communication of `Task` with `TaskManager`. No one except `TaskManager` should directly communicate with `Task`. So it can be safely remove legacy class `TaskExecutionStateListener`.
   
   ## Brief change log
   
   - Wholly Remove `ActorGatewayTaskExecutionStateListener.java` and `TaskExecutionStateListener.java`
   - Graceful remove inactive usage of these class in `Task.java`
   - Refine `TaskTest.java` and `StreamTaskTest.java`
   
   ## Verifying this change
   
   Since it is a removal, make sure existing tests pass is enough.
   
   cc @tillrohrmann @GJL @twalthr 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services