[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

[GitBox <gi...@apache.org>]

williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-386489306
 
 
   all right things are going to get crazier from here, I was advised to not waste time getting the `CommonsChunksPlugin` to work and instead move to the webpack 4 hotness 🔥. I have a working (locally) version of that change, so could do that in another PR or could add it to this mix. @mistercrunch do you have any preference on that? they're both non-trivial changes I think, webpack v4 will require `"node": ">= 6.11.5 <7.0.0 || >= 8.9.0"` which means chef/backend config changes (cc @john-bodley)
   
   Just for fun-sies I tried the changes here on top of the webpack 4 change and we are going going to generate a crazy number of bundles (because it does basically all of the shared chunk-ing you described above). [this is a good overview article](https://medium.com/webpack/webpack-4-code-splitting-chunk-graph-and-the-splitchunks-optimization-be739a861366).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org