You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2018/05/02 20:37:24 UTC

[GitHub] spark pull request #21163: [SPARK-24097][ML] Instruments improvements - Rand...

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21163#discussion_r185628460
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
    @@ -22,12 +22,11 @@ import java.io.IOException
     import scala.collection.mutable
     import scala.util.Random
     
    -import org.apache.spark.internal.Logging
     import org.apache.spark.ml.classification.DecisionTreeClassificationModel
     import org.apache.spark.ml.feature.LabeledPoint
     import org.apache.spark.ml.regression.DecisionTreeRegressionModel
     import org.apache.spark.ml.tree._
    -import org.apache.spark.ml.util.Instrumentation
    +import org.apache.spark.ml.util.{Instrumentation, OptionalInstrumentation}
    --- End diff --
    
    Instrumentation is no longer needed


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org