You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/11/05 23:11:15 UTC

[GitHub] spark pull request #22087: [SPARK-25097][ML] Support prediction on single in...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22087#discussion_r230948830
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
    @@ -117,7 +117,8 @@ class BisectingKMeansModel private[ml] (
         validateAndTransformSchema(schema)
       }
     
    -  private[clustering] def predict(features: Vector): Int = parentModel.predict(features)
    +  @Since("2.4.0")
    --- End diff --
    
    This would have to be 3.0.0.
    
    I don't see a good reason not to expose this. CCing also maybe @mgaido91 ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org