You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/11/13 21:02:18 UTC

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #524: respect commit.manifest.min.count

rdblue commented on a change in pull request #524: respect commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#discussion_r345999607
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
 ##########
 @@ -279,7 +284,6 @@ protected void add(ManifestFile manifest) {
           COMMA.join(Iterables.transform(Iterables.filter(deletePaths,
               path -> !deletedFiles.contains(path)),
               CharSequenceWrapper::get)));
-
 
 Review comment:
   Please revert non-functional changes like this. These tend to cause needless git commit conflicts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org