You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2023/01/05 06:41:41 UTC
[GitHub] [ratis] SzyWilliam opened a new pull request, #803: RATIS-1765. [GrpcLogAppender] Calculate streaming md5 file-wise when installSnapshot
SzyWilliam opened a new pull request, #803:
URL: https://github.com/apache/ratis/pull/803
## What changes were proposed in this pull request?
Stream MD5 is introduced by https://github.com/apache/ratis/commit/db3623a22e39a7957d9985fc9fe6784fe977f070 to reduce duplicate IO costs. However, current implementation calculates MD5 chunk-wise instead of file-wise.
We should calculate MD5 once per file, instead of many times per chunk.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1765
## How was this patch tested?
1. unit tests.
2. new unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] SzyWilliam commented on pull request #803: RATIS-1765. [GrpcLogAppender] Calculate streaming md5 file-wise when installSnapshot
Posted by GitBox <gi...@apache.org>.
SzyWilliam commented on PR #803:
URL: https://github.com/apache/ratis/pull/803#issuecomment-1373628001
@szetszwo Thanks for reviewing this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] SzyWilliam merged pull request #803: RATIS-1765. [GrpcLogAppender] Calculate streaming md5 file-wise when installSnapshot
Posted by GitBox <gi...@apache.org>.
SzyWilliam merged PR #803:
URL: https://github.com/apache/ratis/pull/803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org