You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/01/10 12:28:34 UTC
[GitHub] [sling-org-apache-sling-dynamic-include] rombert opened a new pull
request #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
rombert opened a new pull request #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue
#12: SLING-8982 - dynamic-include: upgrade to parent pom 35
Posted by GitBox <gi...@apache.org>.
rombert commented on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12#issuecomment-573054240
Based on the discussion from [SLING-8987](https://issues.apache.org/jira/browse/SLING-8987) I've removed **all** package exports. My assumption is that none are actually used, but I'll wait for more feedback before proceeding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue
#12: SLING-8982 - dynamic-include: upgrade to parent pom 35
Posted by GitBox <gi...@apache.org>.
rombert commented on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12#issuecomment-573017316
@ericvangeem, @scotty6435 , @briankasingli , @toniedzwiedz - from recent activity you are using SDI in your projects. I have migrated the SDI project to the bnd annotations, it would be great if you could test if things still work with the changes from this PR.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] toniedzwiedz edited a
comment on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
Posted by GitBox <gi...@apache.org>.
toniedzwiedz edited a comment on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12#issuecomment-573306995
@rombert as I said in the JIRA, I haven't personally seen it used this way. However, just to be on the safe side, I've asked my colleagues at Cognifide. I'll let you know if anyone has done it.
> I have migrated the SDI project to the bnd annotations, it would be great if you could test if things still work with the changes from this PR.
Sounds good. I'll see what I can do next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] rombert merged pull
request #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
Posted by GitBox <gi...@apache.org>.
rombert merged pull request #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] toniedzwiedz commented on
issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
Posted by GitBox <gi...@apache.org>.
toniedzwiedz commented on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12#issuecomment-573306995
@rombert as I said in the JIRA, I haven't personally seen it used this way. However, just to be on the safe side, I've asked my colleagues at Cognifide. I'll let you know if anyone has done it.
> I have migrated the SDI project to the bnd annotations, it would be great if you could test if things still work with the changes from this PR.
Sounds good. I'll see what I can do next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented
on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #12: SLING-8982 - dynamic-include: upgrade to parent pom 35
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/12#issuecomment-573054456
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B.png' alt='B' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=CODE_SMELL) [17 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=12&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services