You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by co...@apache.org on 2009/10/24 00:33:57 UTC
svn commit: r829269 - in /hadoop/common/trunk: CHANGES.txt
src/test/aop/build/aop.xml
Author: cos
Date: Fri Oct 23 22:33:57 2009
New Revision: 829269
URL: http://svn.apache.org/viewvc?rev=829269&view=rev
Log:
HADOOP-6326. Hundson runs should check for AspectJ warnings and report failure if any is present. Contributed by Konstantin Boudnik
Modified:
hadoop/common/trunk/CHANGES.txt
hadoop/common/trunk/src/test/aop/build/aop.xml
Modified: hadoop/common/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/CHANGES.txt?rev=829269&r1=829268&r2=829269&view=diff
==============================================================================
--- hadoop/common/trunk/CHANGES.txt (original)
+++ hadoop/common/trunk/CHANGES.txt Fri Oct 23 22:33:57 2009
@@ -27,6 +27,9 @@
HADOOP-6312. Remove unnecessary debug logging in Configuration constructor.
(Aaron Kimball via cdouglas)
+ HADOOP-6326. Hundson runs should check for AspectJ warnings and report
+ failure if any is present (cos)
+
OPTIMIZATIONS
BUG FIXES
Modified: hadoop/common/trunk/src/test/aop/build/aop.xml
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/src/test/aop/build/aop.xml?rev=829269&r1=829268&r2=829269&view=diff
==============================================================================
--- hadoop/common/trunk/src/test/aop/build/aop.xml (original)
+++ hadoop/common/trunk/src/test/aop/build/aop.xml Fri Oct 23 22:33:57 2009
@@ -17,6 +17,7 @@
<project name="aspects">
<property name="build-fi.dir" value="${basedir}/build-fi"/>
<property name="hadoop-fi.jar" location="${build.dir}/${final.name}-fi.jar" />
+ <property name="compile-inject.output" value="${build-fi.dir}/compile-fi.log"/>
<property name="aspectversion" value="1.6.4"/>
<property file="${basedir}/build.properties"/>
@@ -53,12 +54,26 @@
deprecation="${javac.deprecation}">
<classpath refid="test.classpath"/>
</iajc>
+ <loadfile property="injection.failure" srcfile="${compile-inject.output}">
+ <filterchain>
+ <linecontainsregexp>
+ <regexp pattern='iajc.*warning'/>
+ </linecontainsregexp>
+ </filterchain>
+ </loadfile>
+ <fail if="injection.failure">
+ Broken binding of advises: ${line.separator}${injection.failure}
+ </fail>
<echo message="Weaving of aspects is finished"/>
</target>
<target name="injectfaults"
description="Instrument classes with faults and other AOP advices">
- <subant buildpath="${basedir}" target="compile-fault-inject">
+ <!--mkdir to prevent <subant> failure in case the folder has been removed-->
+ <mkdir dir="${build-fi.dir}"/>
+ <delete file="${compile-inject.output}"/>
+ <subant buildpath="${basedir}" target="compile-fault-inject"
+ output="${compile-inject.output}">
<property name="build.dir" value="${build-fi.dir}"/>
</subant>
</target>