You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2019/09/26 14:44:40 UTC
[commons-rng] 01/03: Reduce RandomSourceInternal method scope where
possible.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 63f0f63e315af66a521ea60627993b3e4b4208f8
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Sep 26 15:35:03 2019 +0100
Reduce RandomSourceInternal method scope where possible.
---
.../apache/commons/rng/simple/internal/ProviderBuilder.java | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
index 02af9fc..d9e394e 100644
--- a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
+++ b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
@@ -256,12 +256,12 @@ public final class ProviderBuilder {
3,
NativeSeedType.LONG_ARRAY) {
@Override
- Object createSeed() {
+ protected Object createSeed() {
return createMswsSeed(SeedFactory.createLong());
}
@Override
- Object convertSeed(Object seed) {
+ protected Object convertSeed(Object seed) {
// Allow seeding with primitives to generate a good seed
if (seed instanceof Integer) {
return createMswsSeed((Integer) seed);
@@ -474,7 +474,7 @@ public final class ProviderBuilder {
*
* @return the native seed
*/
- Object createSeed() {
+ protected Object createSeed() {
return nativeSeedType.createSeed(nativeSeedSize);
}
@@ -496,11 +496,15 @@ public final class ProviderBuilder {
/**
* Converts a seed from any of the supported seed types to a native seed.
*
+ * <p>The default implementation delegates to the native seed type conversion.</p>
+ *
+ * <p>This method should be over-ridden to satisfy seed requirements for the generator.</p>
+ *
* @param seed Input seed (must not be null).
* @return the native seed
* @throw UnsupportedOperationException if the {@code seed} type is invalid.
*/
- Object convertSeed(Object seed) {
+ protected Object convertSeed(Object seed) {
return nativeSeedType.convertSeed(seed, nativeSeedSize);
}