You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Ran Tao (Jira)" <ji...@apache.org> on 2022/06/02 15:10:00 UTC
[jira] [Updated] (FLINK-27886) Error way for skipping shade plugin in sub-modules
[ https://issues.apache.org/jira/browse/FLINK-27886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ran Tao updated FLINK-27886:
----------------------------
Description:
Currently in some sub-modules, for example, flink-quickstart-java flink-quickstart-scala, flink-walkthrough, we want to skip shade but use error way like this
{code:java}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
</phase>
</execution>
</executions>
</plugin>
{code}
It just set none phase for itself, can't forbid the inherited parent shade.
!screenshot-1.png!
!screenshot-2.png!
the correct way is
{code:java}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
<id>shade-flink</id>
<phase>none</phase>
</execution>
</executions>
</plugin>
{code}
it can forbid parent shade-flink and also it's own shade. because there is no another own shade execution.
was:
Currently in some sub-modules, for example, flink-quickstart-java flink-quickstart-scala, flink-walkthrough, we want to skip shade but use error way like this
{code:java}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
</phase>
</execution>
</executions>
</plugin>
{code}
It just set none phase for itself, can't forbid the inherited parent shade.
the correct way is
{code:java}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
<id>shade-flink</id>
<phase>none</phase>
</execution>
</executions>
</plugin>
{code}
it can forbid parent shade-flink and also it's own shade. because there is no another own shade execution.
> Error way for skipping shade plugin in sub-modules
> --------------------------------------------------
>
> Key: FLINK-27886
> URL: https://issues.apache.org/jira/browse/FLINK-27886
> Project: Flink
> Issue Type: Improvement
> Components: BuildSystem / Shaded
> Affects Versions: 1.15.0, 1.13.6, 1.14.4
> Reporter: Ran Tao
> Priority: Major
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> Currently in some sub-modules, for example, flink-quickstart-java flink-quickstart-scala, flink-walkthrough, we want to skip shade but use error way like this
> {code:java}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-shade-plugin</artifactId>
> <executions>
> <execution>
> </phase>
> </execution>
> </executions>
> </plugin>
> {code}
> It just set none phase for itself, can't forbid the inherited parent shade.
> !screenshot-1.png!
> !screenshot-2.png!
> the correct way is
> {code:java}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-shade-plugin</artifactId>
> <executions>
> <execution>
> <id>shade-flink</id>
> <phase>none</phase>
> </execution>
> </executions>
> </plugin>
> {code}
> it can forbid parent shade-flink and also it's own shade. because there is no another own shade execution.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)