You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/04/26 00:19:06 UTC

[GitHub] [maven-surefire] akomakom edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

akomakom edited a comment on pull request #285:
URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619458497


   I'm fairly convinced that **JAVA_HOME** is not being changed for the test process and is inherited from the parent process.  I'd definitely like it to be, and, assuming that you're on board with that, should it be done in:
   
   * JarManifestForkConfiguration (always)
   * in our `getToolchain()` method by simply modifying environmentVariables Map (if not already set?)
   * someplace else?
   
   On a side note, I believe that the original implementation is **also wrong**.  Even if I set the main maven toolchain to a different JDK via the toolchains plugin configuration, the JAVA_HOME environment variable is inherited from the invoking shell and does not change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org