You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2022/04/13 21:30:59 UTC
[GitHub] [unomi] anatol-sialitski opened a new pull request, #403: UNOMI-487 Add profile alias management to REST API and GraphQL API
anatol-sialitski opened a new pull request, #403:
URL: https://github.com/apache/unomi/pull/403
UNOMI-487 Add profile alias management to REST API and GraphQL API
In scope of this PR was implemented REST API and GraphQL API for profile aliases.
1. Added new ES index `profileAliases`
2. GraphQL API
3. REST API
4. Integration tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber merged pull request #403: UNOMI-487 Add profile alias management to REST API and GraphQL API
Posted by GitBox <gi...@apache.org>.
sergehuber merged PR #403:
URL: https://github.com/apache/unomi/pull/403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] anatol-sialitski commented on a diff in pull request #403: UNOMI-487 Add profile alias management to REST API and GraphQL API
Posted by GitBox <gi...@apache.org>.
anatol-sialitski commented on code in PR #403:
URL: https://github.com/apache/unomi/pull/403#discussion_r850567871
##########
api/src/main/java/org/apache/unomi/api/services/ProfileService.java:
##########
@@ -110,6 +110,10 @@ public interface ProfileService {
void addAliasToProfile(String profileID, String alias, String clientID);
+ ProfileAlias removeAliasFromProfile(String profileID, String alias, String clientID);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on a diff in pull request #403: UNOMI-487 Add profile alias management to REST API and GraphQL API
Posted by GitBox <gi...@apache.org>.
sergehuber commented on code in PR #403:
URL: https://github.com/apache/unomi/pull/403#discussion_r850426736
##########
api/src/main/java/org/apache/unomi/api/services/ProfileService.java:
##########
@@ -110,6 +110,10 @@ public interface ProfileService {
void addAliasToProfile(String profileID, String alias, String clientID);
+ ProfileAlias removeAliasFromProfile(String profileID, String alias, String clientID);
Review Comment:
Could you please add Javadoc for all the profile alias methods ? This is a requirement of the API classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on a diff in pull request #403: UNOMI-487 Add profile alias management to REST API and GraphQL API
Posted by GitBox <gi...@apache.org>.
sergehuber commented on code in PR #403:
URL: https://github.com/apache/unomi/pull/403#discussion_r850426737
##########
api/src/main/java/org/apache/unomi/api/services/ProfileService.java:
##########
@@ -110,6 +110,10 @@ public interface ProfileService {
void addAliasToProfile(String profileID, String alias, String clientID);
+ ProfileAlias removeAliasFromProfile(String profileID, String alias, String clientID);
Review Comment:
Could you please add Javadoc for all the profile alias methods ? This is a requirement of the API classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org