You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/09/30 04:18:00 UTC
[jira] [Commented] (GEODE-8561) be able to request Windows checks
on a PR is desired
[ https://issues.apache.org/jira/browse/GEODE-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204442#comment-17204442 ]
ASF GitHub Bot commented on GEODE-8561:
---------------------------------------
onichols-pivotal opened a new pull request #5572:
URL: https://github.com/apache/geode/pull/5572
In a [recent discussion on the dev list](https://lists.apache.org/x/thread.html/r4d0ad5898654525e59a5367e3ad101a14307118932a6d61fbf3d72cf@%3Cdev.geode.apache.org%3E), some felt it was unnecessary to add Windows PR checks to *every* PR. However at least 8 times this year alone, this has led to changes being committed to develop that broke on Windows, stalling the pipeline.
This poses a problem, because even once you know your commit broke Windows, developers often have no way to test a fix.
A comment from Kirk asked if we could find a way to request extra (Windows) PR checks only for certain PRs, e.g. opt-in once you have found yourself in the position of having to fix a Windows failure.
This enables the PR pipeline to do just that. Ordinary PRs will continue to behave exactly as before. However, if you add the GitHub label "windows" to the PR (just below the reviewers list), additional PR checks for Windows will be run as well. They will never be required checks so as always, you are free to merge before they have finished if you already got what you needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> be able to request Windows checks on a PR is desired
> ----------------------------------------------------
>
> Key: GEODE-8561
> URL: https://issues.apache.org/jira/browse/GEODE-8561
> Project: Geode
> Issue Type: Improvement
> Components: ci
> Reporter: Owen Nichols
> Priority: Major
>
> Inspired by [Kirk's suggestion|https://lists.apache.org/x/thread.html/rd6e7fd90744becd8e613adb9966a93d4ac7dd6cbca317e7c8349b156@%3Cdev.geode.apache.org%3E], a simple way to request Windows PR checks to be run on an individual PR would be by adding the label *windows* to the PR. Labels are a GitHub mechanism that is often overlooked...it shows up just below the list of reviewers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)