You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/02 07:35:18 UTC
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #474: Hide order column for user account
Pearl1594 opened a new pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474
Disables the order column in Templates List View for normal user - Addresses issue: https://github.com/apache/cloudstack-primate/issues/473
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652961391
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#discussion_r448217919
##########
File path: src/views/AutogenView.vue
##########
@@ -485,6 +485,10 @@ export default {
}
}
+ if (!['Admin'].includes(this.$store.getters.userInfo.roletype) && this.apiName === 'listTemplates' && this.selectedFilter !== 'self') {
Review comment:
@rhtyd In the old UI - the order column is shown for all users , but the backend API prevents it from ordering them with the following exception:
```
Domain Admin and regular users can modify only their own Public templates
```
Hence, to adhere to this - I've exposed the order column only for those that it owns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652202323
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652279053
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652291040
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/474 (JID-2175)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#discussion_r448220356
##########
File path: src/views/AutogenView.vue
##########
@@ -485,6 +485,10 @@ export default {
}
}
+ if (!['Admin'].includes(this.$store.getters.userInfo.roletype) && this.apiName === 'listTemplates' && this.selectedFilter !== 'self') {
Review comment:
@Pearl1594 so if an account owns templates, could they update and change order for their own (public) templates? Instead, we can just enforce that the order columns are shown only to the root admin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652204740
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/474 (JID-2169)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652279666
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652965337
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/474 (JID-2195)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652302746
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652303390
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#discussion_r448214497
##########
File path: src/views/AutogenView.vue
##########
@@ -485,6 +485,10 @@ export default {
}
}
+ if (!['Admin'].includes(this.$store.getters.userInfo.roletype) && this.apiName === 'listTemplates' && this.selectedFilter !== 'self') {
Review comment:
@Pearl1594 do we need to check for the selected filter; shouldn't we not display the order column irrespective of that? Maybe check against old UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#discussion_r448221510
##########
File path: src/views/AutogenView.vue
##########
@@ -485,6 +485,10 @@ export default {
}
}
+ if (!['Admin'].includes(this.$store.getters.userInfo.roletype) && this.apiName === 'listTemplates' && this.selectedFilter !== 'self') {
Review comment:
The API allows users and dom admins to change the order of their own public templates. However, I can restrict this only to Root admin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652961962
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652934483
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-653339618
Yup, after the api is executed, the order gets reset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652839501
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652839169
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #474: Hide order column for user account
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #474:
URL: https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652201953
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org