[GitHub] [cassandra-dtest] jacek-lewandowski commented on a diff in pull request #207: aligned tests with CASSANDRA-18043

["jacek-lewandowski (via GitHub)" <gi...@apache.org>]

jacek-lewandowski commented on code in PR #207:
URL: https://github.com/apache/cassandra-dtest/pull/207#discussion_r1136789165


##########
compaction_test.py:
##########
@@ -16,7 +16,7 @@
 logger = logging.getLogger(__name__)
 
 strategies = ['LeveledCompactionStrategy', 'SizeTieredCompactionStrategy', 'DateTieredCompactionStrategy']
-
+strategies_without_dtcs = ['LeveledCompactionStrategy', 'SizeTieredCompactionStrategy']

Review Comment:
   Maybe instead of creating separate lists, and then separate tests for different versions, you would consider creating a function which returns available strategies for a given cluster version, so that the tests would stay mostly version-agnostic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org