[FlexJS] Update Closure compiler?

[Josh Tynjala <jo...@gmail.com>]

Hey all,

I notice that the default Closure compiler version is 20151015. Can we
update to a newer build? I think their externs have been updated, and it's
good to be more up-to-date with those. I also discovered an interesting
change related to how Closure compiler generates source maps. Right now,
Closure compiler generates a source map for a FalconJX release build, but
it only maps to the JavaScript from the debug build. It doesn't read in the
source map that FalconJX generate from ActionScript for the debug build. It
appears that a more recent build of Closure compiler will read in existing
source maps and use them to generate the final source maps. If we update, a
release build from FalconJX should map all the way back to the original
ActionScript instead.

- Josh

Re: [FlexJS] Update Closure compiler?

[Alex Harui <ah...@adobe.com>]

On 12/13/16, 3:50 PM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
<carlos.rovira@gmail.com on behalf of carlos.rovira@codeoscopic.com> wrote:

>I'll try as well a "mvn clean install" so maven continue working :)

I think there is a pom.xml that needs updating to pull in a later Closure
Compiler.

-Alex

Re: [FlexJS] Update Closure compiler?

[Carlos Rovira <ca...@codeoscopic.com>]

I'll try as well a "mvn clean install" so maven continue working :)

2016-12-14 0:46 GMT+01:00 Alex Harui <ah...@adobe.com>:

>
>
> On 12/13/16, 3:34 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>
> >Hey all,
> >
> >I notice that the default Closure compiler version is 20151015. Can we
> >update to a newer build?
>
> Sure, give it a try.  First, before making any changes, I suggest you
> verify you can do the following:
>
> In flex-falcon, run "ant wipe-all", then "ant all"
> In flex-typedefs, run "ant wipe", then "ant".
> In flex-asjs, run "ant super-clean", then "ant main checkintests"
> Then in flex-asjs, go to examples\flexjs\DataBindingExample and run "ant".
>
> If all of that works, change the link to Closure Compiler in flex-falcon
> in the downloads.xml file and perform those steps again.
> Keep an eye out for lots of new warnings from GCC when compiling
> DataBindingExample.  If the output is the same, you are good to go,
> otherwise we might need to force a Google Closure Library update as well.
>
> Thanks,
> -Alex
>
>


-- 

Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es

Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.

De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.

Re: [FlexJS] Update Closure compiler?

[Alex Harui <ah...@adobe.com>]

On 12/13/16, 3:34 PM, "Josh Tynjala" <jo...@gmail.com> wrote:

>Hey all,
>
>I notice that the default Closure compiler version is 20151015. Can we
>update to a newer build?

Sure, give it a try.  First, before making any changes, I suggest you
verify you can do the following:

In flex-falcon, run "ant wipe-all", then "ant all"
In flex-typedefs, run "ant wipe", then "ant".
In flex-asjs, run "ant super-clean", then "ant main checkintests"
Then in flex-asjs, go to examples\flexjs\DataBindingExample and run "ant".

If all of that works, change the link to Closure Compiler in flex-falcon
in the downloads.xml file and perform those steps again.
Keep an eye out for lots of new warnings from GCC when compiling
DataBindingExample.  If the output is the same, you are good to go,
otherwise we might need to force a Google Closure Library update as well.

Thanks,
-Alex