You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/11/10 01:39:32 UTC

[jira] Created: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

add ability for operator to examine state of watches currently registered with a server
---------------------------------------------------------------------------------------

                 Key: ZOOKEEPER-572
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
             Project: Zookeeper
          Issue Type: Improvement
            Reporter: Patrick Hunt
            Assignee: Patrick Hunt
             Fix For: 3.3.0


it may be useful for an operator to examine the watches registered with a server by the various connected sessions

seems useful to allow:

1) watches on a session
2) watches on a path
3) all watches?


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804666#action_12804666 ] 

Hadoop QA commented on ZOOKEEPER-572:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12431329/ZOOKEEPER-572.patch
  against trunk revision 902694.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/55/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/55/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/55/console

This message is automatically generated.

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Component/s: server
                 jmx
    Description: 
it may be useful for an operator to examine the watches registered with a server by the various connected sessions

seems useful to allow:

1) watches on a session
2) watches on a path
3) all watches?

command port and JMX.

  was:
it may be useful for an operator to examine the watches registered with a server by the various connected sessions

seems useful to allow:

1) watches on a session
2) watches on a path
3) all watches?



> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804796#action_12804796 ] 

Hadoop QA commented on ZOOKEEPER-572:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12431379/ZOOKEEPER-572.patch
  against trunk revision 902694.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/58/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/58/console

This message is automatically generated.

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Status: Patch Available  (was: Open)

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804761#action_12804761 ] 

Hadoop QA commented on ZOOKEEPER-572:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12431365/ZOOKEEPER-572.patch
  against trunk revision 902694.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/56/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/56/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/56/console

This message is automatically generated.

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Comment: was deleted

(was: [best casino|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casinos|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best online casino|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best online casinos|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[beste casino online|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino 
|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino 
|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino 
|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
)

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Status: Patch Available  (was: Open)

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802968#action_12802968 ] 

Patrick Hunt commented on ZOOKEEPER-572:
----------------------------------------

we don't have tests for 4letter words, please review/commit

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Attachment: ZOOKEEPER-572.patch

this adds watch 4letter words (see docs)

verify:
1) I spawn threads for the "expensive" 4letter words now, so verify that I do this correctly
in particular locking while operating (as we don't stop the client thread now for the length of 4l processing)
2) verify that I close the connection properly (again, things like selector locking)
3) obv verify the output

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-572:
------------------------------------

      Resolution: Fixed
    Release Note: Add four letter words for monitoring/administering watches on zookeeper nodes. See zookeeperAdmin.pdf/html for more info.
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. thanks pat.

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Attachment: ZOOKEEPER-572.patch

merged against the latest trunk

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Attachment: ZOOKEEPER-572.patch

Added some docs per Mahadev's excellent suggestion.

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-572:
------------------------------------

    Status: Open  (was: Patch Available)

looks like ZOOKEEPER-655 conflicted with this patch. This patch does not apply to the trunk now. Pat can you update the patch? 

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Status: Open  (was: Patch Available)

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Attachment: ZOOKEEPER-572.patch

Ok, testing the 3 new commands.

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804684#action_12804684 ] 

Mahadev konar commented on ZOOKEEPER-572:
-----------------------------------------

+1 this looks good ..... 
 
one minor nit:
- can you add some javadoc/documentation to SendBufferWriter. That code is a little tricky. more in the form of how the sockets are closing and how the response is getting written to and why the selector wake up calls are necessary.



> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Status: Open  (was: Patch Available)

My bad, there are tests for 4letter words now... I'll update to include.


> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Status: Patch Available  (was: Open)

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805476#action_12805476 ] 

Hudson commented on ZOOKEEPER-572:
----------------------------------

Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/])
    

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-572:
-----------------------------------

    Status: Patch Available  (was: Open)

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "monika (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786707#action_12786707 ] 

monika commented on ZOOKEEPER-572:
----------------------------------

[best casino|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casinos|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best online casino|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best online casinos|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[beste casino online|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino 
|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino 
|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]
[best casino 
|http://devel-rok.informatik.hu-berlin.de/bugzilla/attachment.cgi?id=30]


> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802945#action_12802945 ] 

Hadoop QA commented on ZOOKEEPER-572:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12430911/ZOOKEEPER-572.patch
  against trunk revision 900939.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/41/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/41/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/41/console

This message is automatically generated.

> add ability for operator to examine state of watches currently registered with a server
> ---------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-572.patch
>
>
> it may be useful for an operator to examine the watches registered with a server by the various connected sessions
> seems useful to allow:
> 1) watches on a session
> 2) watches on a path
> 3) all watches?
> command port and JMX.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.