You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2014/10/23 01:28:31 UTC
[GitHub] couchdb-fauxton pull request: Add New Database now opens in tray, ...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/108
Add New Database now opens in tray, not prompt
This PR changes the Add New Database from a prompt() to a tray.
@seanbarclay, if you have time, would you mind taking a glance at this? I'll post a screenshot of the before + after in the jira ticket:
https://issues.apache.org/jira/browse/COUCHDB-2398
** this isn't ready to merge yet. I'd the appearance of the tray to be reviewed. **
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton 2398-add-database-tray-added
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 7b4f07a06dde3e5f1eceecaaeaf116cef1136f7a
Author: Benjamin Keen <be...@gmail.com>
Date: 2014-10-22T23:25:49Z
Add New Database now opens in tray, not prompt
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add New Database now opens in tray, ...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add New Database now opens in tray, ...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/108#issuecomment-60890838
Great work @benkeen this is awesome and I've merged it. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add New Database now opens in tray, ...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/108#issuecomment-60724832
+1 I like this @benkeen, great work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add New Database now opens in tray, ...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/108#issuecomment-60436820
Reviewed with @seanbarclay. I've increased the padding on the Add New Database tray - and for other trays for consistency.
@robertkowalski, this is ready for code review + merge. I'll squish it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---