You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/18 09:24:35 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Pearl1594 opened a new pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138
### Description
This PR provides a means of updating a stopped VM with security groups.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
Advanced Zone with Security Groups:
- Provision to select multiple security groups:
- Displays the security groups associated with the VM as a space separated list in the Details tab of the VM:
- Ensured that the fields do not appear in the Advanced zone Tabs
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1073542439
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6138 (SL-JID-1278)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072270502
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1073538622
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072270690
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072232112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072254635
> Yes it does @weizhouapache , but since it isn't a bug I targeted it for 4.17 - should we move it to 4.16??
@Pearl1594
OK, then no need to move to 4.16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 edited a comment on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
Pearl1594 edited a comment on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072232112
Yes it does @weizhouapache , but since it isn't a bug I targeted it for 4.17 - should we move it to 4.16??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072274901
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6138 (SL-JID-1271)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072230352
@Pearl1594
does the issue exist in 4.16 as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#discussion_r830749683
##########
File path: ui/src/components/view/DetailsTab.vue
##########
@@ -41,14 +41,21 @@
</div>
<div v-else-if="['name', 'type'].includes(item)">
<span v-if="['USER.LOGIN', 'USER.LOGOUT', 'ROUTER.HEALTH.CHECKS', 'FIREWALL.CLOSE', 'ALERT.SERVICE.DOMAINROUTER'].includes(dataResource[item])">{{ $t(dataResource[item].toLowerCase()) }}</span>
- <span v-else>{{ dataResource[item] }}</span>
+ <span v-else>{{ dataResource[item] }}</span>h
Review comment:
@Pearl1594 Does adding the last `h` make any sense?
##########
File path: ui/src/components/view/DetailsTab.vue
##########
@@ -41,14 +41,21 @@
</div>
<div v-else-if="['name', 'type'].includes(item)">
<span v-if="['USER.LOGIN', 'USER.LOGOUT', 'ROUTER.HEALTH.CHECKS', 'FIREWALL.CLOSE', 'ALERT.SERVICE.DOMAINROUTER'].includes(dataResource[item])">{{ $t(dataResource[item].toLowerCase()) }}</span>
- <span v-else>{{ dataResource[item] }}</span>
+ <span v-else>{{ dataResource[item] }}</span>h
</div>
<div v-else-if="['created', 'sent', 'lastannotated'].includes(item)">
- {{ $toLocaleDate(dataResource[item]) }}
+ {{ $toLocaleDate(dataResource[item]) }}h
Review comment:
Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072232112
Yes it does, but since it isn't a bug I targeted it for 4.17 - should we move it to 4.16??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 edited a comment on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
Pearl1594 edited a comment on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072232112
Yes it does @weizhouapache , but since it isn't a bug I targeted it for 4.17 - should we move it to 4.16??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072270690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1072230352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#discussion_r830751063
##########
File path: ui/src/components/view/DetailsTab.vue
##########
@@ -41,14 +41,21 @@
</div>
<div v-else-if="['name', 'type'].includes(item)">
<span v-if="['USER.LOGIN', 'USER.LOGOUT', 'ROUTER.HEALTH.CHECKS', 'FIREWALL.CLOSE', 'ALERT.SERVICE.DOMAINROUTER'].includes(dataResource[item])">{{ $t(dataResource[item].toLowerCase()) }}</span>
- <span v-else>{{ dataResource[item] }}</span>
+ <span v-else>{{ dataResource[item] }}</span>h
Review comment:
my apologies, it's happened by mistake. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6138: ui: Support to specify security groups when updating/editing a VM (adv zone + SG)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6138:
URL: https://github.com/apache/cloudstack/pull/6138#issuecomment-1073539316
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org