You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2018/01/14 19:57:09 UTC
[GitHub] spark pull request #20267: [SPARK-23068][BUILD][RELEASE] doc build error fro...
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/20267
[SPARK-23068][BUILD][RELEASE] doc build error from jekyll does not fail
## What changes were proposed in this pull request?
check exit code. note that not errors are reported via exit code.
also there is still [this](https://github.com/apache/spark/blob/master/dev/create-release/release-build.sh#L259) for make_binary_release we should look at
## How was this patch tested?
manual
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark exitcodereleasescript
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20267
----
commit e2d45f9cc5ce8a84d2795a2e9444ffe0b8e18848
Author: Felix Cheung <fe...@...>
Date: 2018-01-14T19:40:32Z
check exit code from jekyll
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20267: [SPARK-23068][BUILD][RELEASE] doc build error fro...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20267#discussion_r161417524
--- Diff: dev/create-release/release-build.sh ---
@@ -290,6 +290,8 @@ if [[ "$1" == "docs" ]]; then
cd docs
# TODO: Make configurable to add this: PRODUCTION=1
PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" jekyll build
+ ret=$?
+ if [[ $ret != 0 ]]; then exit $ret; fi
--- End diff --
Wait .. `set -e` is in effect. Just to be clear, `jekyll build` exits with non-zero code but `set -e` fails to catch it? I am fine as is if it fixes the issue anyway.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20267
**[Test build #86125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86125/testReport)** for PR 20267 at commit [`e2d45f9`](https://github.com/apache/spark/commit/e2d45f9cc5ce8a84d2795a2e9444ffe0b8e18848).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20267: [SPARK-23068][BUILD][RELEASE] doc build error fro...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20267#discussion_r161444163
--- Diff: dev/create-release/release-build.sh ---
@@ -290,6 +290,8 @@ if [[ "$1" == "docs" ]]; then
cd docs
# TODO: Make configurable to add this: PRODUCTION=1
PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" jekyll build
+ ret=$?
+ if [[ $ret != 0 ]]; then exit $ret; fi
--- End diff --
oh very excellent point. I tested in a script without `set -e`, and did see `set -e` wondering a bit what it wasn't doing.
I guess more digging through the jekyll code.
I did find the `wait` for make_binary_release won't work through - it was said to return exit code 0 if the `wait` was without process ID.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20267
I see. Thanks for info! So, is it ready to go anyway @felixcheung?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20267
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86125/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20267
@sameeragarwal FYI.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20267
**[Test build #86125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86125/testReport)** for PR 20267 at commit [`e2d45f9`](https://github.com/apache/spark/commit/e2d45f9cc5ce8a84d2795a2e9444ffe0b8e18848).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20267: [SPARK-23068][BUILD][RELEASE][WIP] doc build erro...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/20267
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE][WIP] doc build error from ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20267
I'm not 100% sure... I injected some error in jekyll but it stopped immediately.
let me try to match the report condition more closely...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20267: [SPARK-23068][BUILD][RELEASE] doc build error from jekyl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20267
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org