You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/09 19:53:50 UTC

[GitHub] [arrow] paleolimbot opened a new pull request, #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

paleolimbot opened a new pull request, #14905:
URL: https://github.com/apache/arrow/pull/14905

   Reprex using CRAN arrow:
   
   ``` r
   library(arrow, warn.conflicts = FALSE)
   library(dplyr, warn.conflicts = FALSE)
   
   mtcars |>
     arrow_table() |>
     select(mpg, cyl) |> 
     group_by(mpg, cyl) |>
     group_by(cyl, value = "foo") |>
     collect()
   #> # A tibble: 32 × 4
   #> # Groups:   cyl, value [3]
   #>      mpg   cyl value `"foo"`
   #>    <dbl> <dbl> <dbl> <chr>  
   #>  1  21       6     6 foo    
   #>  2  21       6     6 foo    
   #>  3  22.8     4     4 foo    
   #>  4  21.4     6     6 foo    
   #>  5  18.7     8     8 foo    
   #>  6  18.1     6     6 foo    
   #>  7  14.3     8     8 foo    
   #>  8  24.4     4     4 foo    
   #>  9  22.8     4     4 foo    
   #> 10  19.2     6     6 foo    
   #> # … with 22 more rows
   ```
   
   <sup>Created on 2022-12-09 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup>
   
   After this PR:
   
   ``` r
   library(arrow, warn.conflicts = FALSE)
   #> Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.
   library(dplyr, warn.conflicts = FALSE)
   
   mtcars |>
     arrow_table() |>
     select(mpg, cyl) |> 
     group_by(mpg, cyl) |>
     group_by(cyl, value = "foo") |>
     collect()
   #> # A tibble: 32 × 3
   #> # Groups:   cyl, value [3]
   #>      mpg   cyl value
   #>    <dbl> <dbl> <chr>
   #>  1  21       6 foo  
   #>  2  21       6 foo  
   #>  3  22.8     4 foo  
   #>  4  21.4     6 foo  
   #>  5  18.7     8 foo  
   #>  6  18.1     6 foo  
   #>  7  14.3     8 foo  
   #>  8  24.4     4 foo  
   #>  9  22.8     4 foo  
   #> 10  19.2     6 foo  
   #> # … with 22 more rows
   ```
   
   <sup>Created on 2022-12-09 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] paleolimbot commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1347080527

   Is there any opposition to merging this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] paleolimbot merged pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
paleolimbot merged PR #14905:
URL: https://github.com/apache/arrow/pull/14905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1350658425

   Benchmark runs are scheduled for baseline = 16d0eb4dd25fdeb2229b7cd845ccfd0dc54a1c73 and contender = 9753a6720dabf3da1dd97706005adb411e5773ec. 9753a6720dabf3da1dd97706005adb411e5773ec is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:25.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16fbab4fba624dc6985012d65647103f...29b35327d6844e6bab720b52e584a02a/)
   [Finished :arrow_down:0.5% :arrow_up:0.23%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/47c0d76977b547b3b2c14802f7bfe3dd...aacce1c5f0ef44e6b97c5b2d47ccc253/)
   [Finished :arrow_down:12.5% :arrow_up:4.35%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/78c3e4a305014ce99d82cb89210da4c3...746f4c407326474b8d7c56174b41ec6e/)
   [Finished :arrow_down:11.16% :arrow_up:6.79%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2f2ed974b496467fa33f27d49b4d51ba...d72355a15c684a0aa878b86d36c15009/)
   Buildkite builds:
   [Finished] [`9753a672` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1992)
   [Finished] [`9753a672` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2014)
   [Finished] [`9753a672` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1984)
   [Finished] [`9753a672` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2006)
   [Finished] [`16d0eb4d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1991)
   [Finished] [`16d0eb4d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2013)
   [Finished] [`16d0eb4d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1983)
   [Finished] [`16d0eb4d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2005)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] paleolimbot commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1346425713

   I did add a test that covers that case (and made sure it failed on current master); however, the test I added matches the style and content the tests around it (e.g., they all use `example_data` and `compare_dplyr_binding()`). Is there something that the example is testing that wasn't covered by the test that I added that I missed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1344725727

   :warning: GitHub issue #14872 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] eitsupi commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
eitsupi commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1345177414

   > ```r
   > library(arrow, warn.conflicts = FALSE)
   > #> Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.
   > library(dplyr, warn.conflicts = FALSE)
   > 
   > mtcars |>
   >   arrow_table() |>
   >   select(mpg, cyl) |> 
   >   group_by(mpg, cyl) |>
   >   group_by(cyl, value = "foo") |>
   >   collect()
   > ```
   
   Wouldn't it be better to add this example to the test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] paleolimbot commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1346539332

   It's definitely worth adding a test! Thanks @eitsupi for the catch. It's definitely related to this PR...the overlapping groups thing results in some very odd arguments to the `mutate()` embedded in `group_by()`, which results in all sorts of crazy things happening.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1344725697

   * Closes: #14872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] eitsupi commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
eitsupi commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1346430635

   > Is there something that the example is testing that wasn't covered by the test that I added that I missed?
   
   I thought an example of defining a new column in `group_by` would that case.
   It seems quite surprising that both `value` and `"foo"` columns are generated in the following example.
   
   > ```r
   > library(arrow, warn.conflicts = FALSE)
   > library(dplyr, warn.conflicts = FALSE)
   > 
   > mtcars |>
   >   arrow_table() |>
   >   select(mpg, cyl) |> 
   >   group_by(mpg, cyl) |>
   >   group_by(cyl, value = "foo") |>
   >   collect()
   > ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14905: GH-14872: [R] arrow returns wrong variable content when multiple group_by/summarise statements are used

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14905:
URL: https://github.com/apache/arrow/pull/14905#issuecomment-1350658902

   ['Python', 'R'] benchmarks have high level of regressions.
   [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/78c3e4a305014ce99d82cb89210da4c3...746f4c407326474b8d7c56174b41ec6e/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org