You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/04/24 20:48:00 UTC

[jira] [Commented] (NIFI-6170) During connection configuration, if required fields are empty, improve error pop-up and do not close configuration window

    [ https://issues.apache.org/jira/browse/NIFI-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825494#comment-16825494 ] 

ASF subversion and git services commented on NIFI-6170:
-------------------------------------------------------

Commit 31463c5dad38be0dcb5f8872c4b423f1f01cc786 in nifi's branch refs/heads/master from Koji Kawamura
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=31463c5 ]

NIFI-6160 Apply config error handling convention

What this PR changed:
- Standardized required name error message to 'The name of the xxxx must
be specified'
- Added nfErrorHandler.handleConfigurationUpdateAjaxError
    - Replaced existing custom error handling for 400 status code
    - Replaced handleAjxError with this where appropriate
- Standardized config error dialog title to 'Configuration Error'
- Close the configuration dialog when configuration is successfully
updated

Above convention applied to following components:
- ProcessGroup
- Input/OutputPort
- RemoteProcessGroup
    - RemoteGroupPort
- Template
- Connection
- ControllerService
- Label
- Processor
- ReportingTask
- NiFi Settings/GENERAL tab
- Variable
- User

NIFI-6170 Provide consistent UX at Connection config
Fixed Label.

Incorporated review comments
Removed unnecessary else block.
Disable canvas when the message pane is shown

This closes #3401


> During connection configuration, if required fields are empty, improve error pop-up and do not close configuration window
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-6170
>                 URL: https://issues.apache.org/jira/browse/NIFI-6170
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>            Reporter: Andrew Lim
>            Assignee: Koji Kawamura
>            Priority: Minor
>
> Should make Connection configuration consistent UX with Processor configuration and RPG creation where those dialogs only close with a successful 200.
> For Connection configuration, if a required field like Back Pressure Object Threshold is missing:
>  * open a pop-up with the title "Configuration Error"
>  * the message should say "Back pressure object threshold must be an integer value"
>  * Selecting OK returns the user to the "Connection Configuration" window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)