You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/10/17 10:11:29 UTC
Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java f307cccfc634d7742ca13da50169e88e56e98613
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 82e023146c0290b5a1e0146a550b6f7a55e7e1b2
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review152869
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java (line 42)
<https://reviews.apache.org/r/52924/#comment222034>
This needs to be done based on cost in post estimate.
- Puneet Gupta
On Oct. 17, 2016, 12:08 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 12:08 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
> src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
>
> Diff: https://reviews.apache.org/r/52924/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review153518
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On Oct. 19, 2016, 12:06 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2016, 12:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION
> lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
> lens-server/src/main/resources/lensserver-default.xml 8e5fe8a2b7f9ddfcadef104189b89c40ca1b3df6
> pom.xml 4928c1fa840fc51e4383ed4803f94102aa833221
> src/site/apt/admin/config.apt f22fc0c36f53fa7227dc990c58a079e66630a2a1
> src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
>
> Diff: https://reviews.apache.org/r/52924/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Nov. 11, 2016, 3:36 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7ccb17081032024352fe03509a90ac8429254d66
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
lens-server/src/main/resources/lensserver-default.xml e652a0f781b0adc47b0e4bd8f11fd07eed37fa90
lens-server/src/test/resources/drivers/hive/hive1/hivedriver-site.xml 50985b5447aee22b066567bf7c40fb5eee591862
lens-server/src/test/resources/drivers/hive/hive2/hivedriver-site.xml b485100dbe85d5b04db25ebef9affdbed8afeb31
pom.xml 29c59d3a06b3556ce5704bc409c4117b1ecd3f6e
src/site/apt/admin/config.apt f89caabeb0050df73ffc235bc3e144b64392b77d
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Nov. 11, 2016, 1:09 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7ccb17081032024352fe03509a90ac8429254d66
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
lens-server/src/main/resources/lensserver-default.xml e652a0f781b0adc47b0e4bd8f11fd07eed37fa90
lens-server/src/test/resources/drivers/hive/hive1/hivedriver-site.xml 50985b5447aee22b066567bf7c40fb5eee591862
lens-server/src/test/resources/drivers/hive/hive2/hivedriver-site.xml b485100dbe85d5b04db25ebef9affdbed8afeb31
pom.xml 29c59d3a06b3556ce5704bc409c4117b1ecd3f6e
src/site/apt/admin/config.apt f89caabeb0050df73ffc235bc3e144b64392b77d
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Nov. 11, 2016, 12:32 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7ccb17081032024352fe03509a90ac8429254d66
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
lens-server/src/main/resources/lensserver-default.xml e652a0f781b0adc47b0e4bd8f11fd07eed37fa90
lens-server/src/test/resources/drivers/hive/hive1/hivedriver-site.xml 50985b5447aee22b066567bf7c40fb5eee591862
lens-server/src/test/resources/drivers/hive/hive2/hivedriver-site.xml b485100dbe85d5b04db25ebef9affdbed8afeb31
pom.xml 29c59d3a06b3556ce5704bc409c4117b1ecd3f6e
src/site/apt/admin/config.apt f89caabeb0050df73ffc235bc3e144b64392b77d
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Nov. 10, 2016, 1:41 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java cf1c233a58fd8b5f5ead95b3fe9066d63976d595
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
lens-server/src/main/resources/lensserver-default.xml 0ac722d7788f610d2e4b81cef8f1f120dcf221ca
lens-server/src/test/resources/drivers/hive/hive1/hivedriver-site.xml 50985b5447aee22b066567bf7c40fb5eee591862
lens-server/src/test/resources/drivers/hive/hive2/hivedriver-site.xml b485100dbe85d5b04db25ebef9affdbed8afeb31
pom.xml 29c59d3a06b3556ce5704bc409c4117b1ecd3f6e
src/site/apt/admin/config.apt 21b23f9075326b4a10ab57eb1febf06f81f33b4b
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Nov. 4, 2016, 2:19 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8f9db2a53e1ad338fe4817561857e8e158c3741f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
lens-server/src/main/resources/lensserver-default.xml a00048b96ea9018f7d6ad44ec110d37056ec03b3
lens-server/src/test/resources/drivers/hive/hive1/hivedriver-site.xml 50985b5447aee22b066567bf7c40fb5eee591862
lens-server/src/test/resources/drivers/hive/hive2/hivedriver-site.xml b485100dbe85d5b04db25ebef9affdbed8afeb31
pom.xml 29c59d3a06b3556ce5704bc409c4117b1ecd3f6e
src/site/apt/admin/config.apt 4d49781faa454d0a5944b6cce0694de732fc2ef7
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Nov. 4, 2016, 12:26 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8f9db2a53e1ad338fe4817561857e8e158c3741f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
lens-server/src/main/resources/lensserver-default.xml a00048b96ea9018f7d6ad44ec110d37056ec03b3
lens-server/src/test/resources/drivers/hive/hive1/hivedriver-site.xml 50985b5447aee22b066567bf7c40fb5eee591862
lens-server/src/test/resources/drivers/hive/hive2/hivedriver-site.xml b485100dbe85d5b04db25ebef9affdbed8afeb31
pom.xml 29c59d3a06b3556ce5704bc409c4117b1ecd3f6e
src/site/apt/admin/config.apt 4d49781faa454d0a5944b6cce0694de732fc2ef7
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Oct. 19, 2016, 5:36 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
lens-server/src/main/resources/lensserver-default.xml 8e5fe8a2b7f9ddfcadef104189b89c40ca1b3df6
pom.xml 4928c1fa840fc51e4383ed4803f94102aa833221
src/site/apt/admin/config.apt f22fc0c36f53fa7227dc990c58a079e66630a2a1
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review153254
-----------------------------------------------------------
lens-driver-hive/src/main/resources/hivedriver-default.xml (line 38)
<https://reviews.apache.org/r/52924/#comment222531>
lens-driver-hive/src/main/resources/hivedriver-default.xml (line 38)
<https://reviews.apache.org/r/52924/#comment222532>
We can stop supporting the old property "lens.driver.hive.query.hook.class" since we are chnaging the package anyway (incomptible change)
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java (line 22)
<https://reviews.apache.org/r/52924/#comment222536>
Package change is an incompatible change for people implementing their hooks. Can we leave and comment of JIRA and also tag it incompatible
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java (line 36)
<https://reviews.apache.org/r/52924/#comment222537>
Comment needs update.
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java (line 131)
<https://reviews.apache.org/r/52924/#comment222540>
This should be the driver that created this hook (and not selected driver)
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java (line 74)
<https://reviews.apache.org/r/52924/#comment222545>
Can we move the parser to non error package ?
- Puneet Gupta
On Oct. 18, 2016, 2:35 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 2:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/parse/Parser.java PRE-CREATION
> lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
> lens-server/src/main/resources/lensserver-default.xml 8e5fe8a2b7f9ddfcadef104189b89c40ca1b3df6
> pom.xml 4928c1fa840fc51e4383ed4803f94102aa833221
> src/site/apt/admin/config.apt f22fc0c36f53fa7227dc990c58a079e66630a2a1
> src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
>
> Diff: https://reviews.apache.org/r/52924/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Oct. 18, 2016, 8:05 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/parse/Parser.java PRE-CREATION
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 476855021288ff0d91762d240cb04c8aea9d302b
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
lens-server/src/main/resources/lensserver-default.xml 8e5fe8a2b7f9ddfcadef104189b89c40ca1b3df6
pom.xml 4928c1fa840fc51e4383ed4803f94102aa833221
src/site/apt/admin/config.apt f22fc0c36f53fa7227dc990c58a079e66630a2a1
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Oct. 18, 2016, 3:10 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/FactPartitionBasedQueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 4712f11e94f93d34b71f4f3ddb7c19af003d9fca
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/FactPartitionBasedQueryCostBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
pom.xml 4928c1fa840fc51e4383ed4803f94102aa833221
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Oct. 17, 2016, 5:38 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Oct. 17, 2016, 5:23 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Oct. 17, 2016, 4:22 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review152845
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java (line 38)
<https://reviews.apache.org/r/52924/#comment222011>
Can we add a simple test case for this? To keep it simple we can use mutiple usser hooks in the chain and test pre rewrite.
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java (line 28)
<https://reviews.apache.org/r/52924/#comment222007>
Should we add class level documentation expaling when this will be useful ?
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java (lines 31 - 32)
<https://reviews.apache.org/r/52924/#comment222009>
Can we use a Set instead for faster search/conatins opeartion ?
- Puneet Gupta
On Oct. 17, 2016, 10:25 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 10:25 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
> src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
>
> Diff: https://reviews.apache.org/r/52924/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 52924: LENS-1359: Add driver hooks for user based
filtering of queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
-----------------------------------------------------------
(Updated Oct. 17, 2016, 3:55 p.m.)
Review request for lens.
Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 43b33f331f4d9017d76bccbe0f6936aaeb184f8f
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 961ec4ec781d3d7fd0f28edc4f23e9b39549592f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 8f30aa06ab234cedb53acb17544210ba4190ab53
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java 69a1a0b7ce57c24602a17ea7c97c0664a77c6568
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java f8a9ee07d8c8b737a41de339ab44ca7752c90748
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 146223942d05cfd952599297144e2a6bc02df273
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 4f1f2eb99ed0bec8e6e471a9723a6b002a092202
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java f70979abf7c44d3b4ed3588628de5a7517adfa81
src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635
Diff: https://reviews.apache.org/r/52924/diff/
Testing
-------
Thanks,
Rajat Khandelwal