You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/20 16:17:16 UTC
[GitHub] [pulsar] andrasbeni opened a new pull request, #17750: [fix][cli] Quti PerformanceConsumer after receiving numMessages messages
andrasbeni opened a new pull request, #17750:
URL: https://github.com/apache/pulsar/pull/17750
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #17747
### Motivation
`PerformanceConsumer` command line tool does not use its `-m` flag thus misleading its users.
### Modifications
Check the total number of messages received against `numMessages` if the latter is non-zero.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change can be verified as follows:
- *Run the reproduction steps in issue #17747 and see the expected behavior*
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
This is a bugfix
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17750: [fix][cli] Quit PerformanceConsumer after receiving numMessages messages
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17750: [fix][cli] Quit PerformanceConsumer after receiving numMessages messages
URL: https://github.com/apache/pulsar/pull/17750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17750: [fix][cli] Quit PerformanceConsumer after receiving numMessages messages
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17750:
URL: https://github.com/apache/pulsar/pull/17750#issuecomment-1255866568
Closing and reopening because pulsarbot did not rerun checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17750: [fix][cli] Quit PerformanceConsumer after receiving numMessages messages
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17750:
URL: https://github.com/apache/pulsar/pull/17750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni closed pull request #17750: [fix][cli] Quit PerformanceConsumer after receiving numMessages messages
Posted by GitBox <gi...@apache.org>.
andrasbeni closed pull request #17750: [fix][cli] Quit PerformanceConsumer after receiving numMessages messages
URL: https://github.com/apache/pulsar/pull/17750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17750: [fix][cli] Quit PerformanceConsumer after receiving numMessages messages
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17750:
URL: https://github.com/apache/pulsar/pull/17750#issuecomment-1255402557
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17750: [fix][cli] Quit PerformanceConsumer after receiving numMessages messages
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17750:
URL: https://github.com/apache/pulsar/pull/17750#issuecomment-1255786420
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org