You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2019/12/24 16:02:03 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #8:
devif_poll_tcp_timer shouldn't be skipped in the multiple card case
xiaoxiang781216 opened a new pull request #8: devif_poll_tcp_timer shouldn't be skipped in the multiple card case
URL: https://github.com/apache/incubator-nuttx/pull/8
devif_timer will be called multiple time in one period if the multiple card exist,
the elapsed time calculated for the first callback is right, but the flowing callback
in the same period is wrong(very short) because the global variable g_polltimer is
used in the calculation.
so let's pass the delay time to devif_timer and remove g_polltimer.
Change-Id: I6ac3d1135e08cc0f34c51916fa713bd6e6892d04
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #8:
devif_poll_tcp_timer shouldn't be skipped in the multiple card case
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #8: devif_poll_tcp_timer shouldn't be skipped in the multiple card case
URL: https://github.com/apache/incubator-nuttx/pull/8#issuecomment-568776573
Correct if there is a problem. This is a duplicate of PR 4, correct. PR 4 was merged via patch. If there is more to be done. Please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo closed pull request #8:
devif_poll_tcp_timer shouldn't be skipped in the multiple card case
Posted by GitBox <gi...@apache.org>.
patacongo closed pull request #8: devif_poll_tcp_timer shouldn't be skipped in the multiple card case
URL: https://github.com/apache/incubator-nuttx/pull/8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services