You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/13 21:24:39 UTC
[GitHub] [beam] lukecwik opened a new pull request #11126: [WIP][BEAM-9430]
Migrate from ProcessContext#updateWatermark to WatermarkEstimators
lukecwik opened a new pull request #11126: [WIP][BEAM-9430] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#issuecomment-600284951
CC: @boyuanzz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#issuecomment-600676765
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#issuecomment-601256891
R: @ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#issuecomment-600715890
R: @ihji
CC: @chamikaramj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik removed a comment on issue #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik removed a comment on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#issuecomment-600715890
R: @ihji
CC: @chamikaramj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mxm commented on a change in pull request #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
mxm commented on a change in pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#discussion_r395145834
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##########
@@ -265,18 +265,6 @@
* data has been explicitly requested. See {@link Window} for more information.
*/
public abstract PaneInfo pane();
-
- /**
- * Gives the runner a (best-effort) lower bound about the timestamps of future output associated
- * with the current element.
- *
- * <p>If the {@link DoFn} has multiple outputs, the watermark applies to all of them.
- *
- * <p>Only splittable {@link DoFn DoFns} are allowed to call this method. It is safe to call
- * this method from a different thread than the one running {@link ProcessElement}, but all
- * calls must finish before {@link ProcessElement} returns.
- */
- public abstract void updateWatermark(Instant watermark);
Review comment:
This is a backwards-incompatible change. It probably does not affect many users but we should make sure to announce it, e.g. via the release notes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#issuecomment-600287442
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik merged pull request #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik merged pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#issuecomment-600284307
R: @mxm @iemejia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430,
BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#issuecomment-600343432
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #11126:
[BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to
WatermarkEstimators
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#discussion_r395178340
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##########
@@ -265,18 +265,6 @@
* data has been explicitly requested. See {@link Window} for more information.
*/
public abstract PaneInfo pane();
-
- /**
- * Gives the runner a (best-effort) lower bound about the timestamps of future output associated
- * with the current element.
- *
- * <p>If the {@link DoFn} has multiple outputs, the watermark applies to all of them.
- *
- * <p>Only splittable {@link DoFn DoFns} are allowed to call this method. It is safe to call
- * this method from a different thread than the one running {@link ProcessElement}, but all
- * calls must finish before {@link ProcessElement} returns.
- */
- public abstract void updateWatermark(Instant watermark);
Review comment:
Sounds good. Will open a PR to edit the release notes as follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services