You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/26 03:06:00 UTC
[jira] [Work logged] (BEAM-4843) Incorrect docs on
FileSystems.delete
[ https://issues.apache.org/jira/browse/BEAM-4843?focusedWorklogId=127633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127633 ]
ASF GitHub Bot logged work on BEAM-4843:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/18 03:05
Start Date: 26/Jul/18 03:05
Worklog Time Spent: 10m
Work Description: ryan-williams opened a new pull request #6071: [BEAM-4843] remove outdated FileSystem deletion docs
URL: https://github.com/apache/beam/pull/6071
As noted in the JIRA, `DeleteOptions` doesn't exist (and afaict never did?)
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 127633)
Time Spent: 10m
Remaining Estimate: 0h
> Incorrect docs on FileSystems.delete
> ------------------------------------
>
> Key: BEAM-4843
> URL: https://issues.apache.org/jira/browse/BEAM-4843
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.6.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [The docs on {{FileSystems.delete}} say|https://github.com/apache/beam/blob/b5e8335d982ee69d9f788f65f27356cddd5293d1/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java#L332-L333]:
> bq. It is allowed but not recommended to delete directories recursively. Callers depends on {@link FileSystems} and uses {@code DeleteOptions}.
> However, the function actually takes a {{MoveOptions...}} param, there's never been a {{DeleteOptions}} afaict, and there is no way to recursively delete a {{ResourceId}}.
> The docs should be fixed, at a minimum; actually supporting recursive delete would also be nice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)