[GitHub] [apisix] Demogorgon314 commented on a change in pull request #4313: feat: nacos discovery support namespace

[GitBox <gi...@apache.org>]

Demogorgon314 commented on a change in pull request #4313:
URL: https://github.com/apache/apisix/pull/4313#discussion_r640209799



##########
File path: apisix/discovery/nacos.lua
##########
@@ -254,10 +264,10 @@ local function fetch_full_registry(premature)
         applications = up_apps
         return
     end
-
     local data, err
-    for _, service_name in ipairs(infos) do
-        data, err = get_url(base_uri, instance_list_path .. service_name .. token_param)
+    for _, service_info in ipairs(infos) do
+        local namespace_param = get_namespace_param(service_info.nacos_namespace_id);
+        data, err = get_url(base_uri, instance_list_path .. service_info.service_name .. token_param .. namespace_param)

Review comment:
       fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org