You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/08/21 03:53:33 UTC

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

aooohan commented on code in PR #33:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r950782169


##########
src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.tomcat.jakartaee;
+
+import static org.junit.Assert.assertTrue;

Review Comment:
   Please do not use static import.



##########
src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.tomcat.jakartaee;
+
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+
+public class ManifestConverterTest {
+
+	@Test
+    public void testAccepts() {

Review Comment:
   Note the code format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org