You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2013/06/16 10:59:20 UTC
[jira] [Commented] (OFBIZ-4472) New elements
auto-parameters-[entity/service] for link/hyperlink
[ https://issues.apache.org/jira/browse/OFBIZ-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684605#comment-13684605 ]
Jacques Le Roux commented on OFBIZ-4472:
----------------------------------------
Hi Nicolas, I reviewed a 1st part today (WidgetWorker.java really thorough) and found 2 possible (though unlikely) NPEs in the 2 WidgetWorker.getParametersMap() methods. When the dispatcher or delegator are null better to return directly the empty map, after showing the error message in log.
Also in formatting avoid
if (! excludeList.contains(paramName)) {
prefer
if (!excludeList.contains(paramName)) {
I'd really appreciate reviews and tests by others (Neogia team? ;) ) before committing
Thanks!
> New elements auto-parameters-[entity/service] for link/hyperlink
> ----------------------------------------------------------------
>
> Key: OFBIZ-4472
> URL: https://issues.apache.org/jira/browse/OFBIZ-4472
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Affects Versions: Screen Widget Redesign, SVN trunk
> Reporter: Nicolas Malin
> Priority: Minor
> Attachments: OFBIZ-4472.patch, OFBIZ-4472.patch, OFBIZ-4472.patch, OFBIZ-4472.patch, OFBIZ-4472.patch
>
>
> When you want edit/remove an entity from link call it's needed to give all pk on parameter element as like :
> {quote} <field name="deleteLink">
> <hyperlink target="example_deleteExampleFeatureAppl">
> <parameter param-name="exampleId"/>
> <parameter param-name="exampleFeatureId"/>
> <parameter param-name="fromDate"/>
> <hyperlink/>
> </field>
> {quote}
> To simplify, I introduce auto-parameters-entity like this :
> {quote}
> <field name="deleteLink">
> <hyperlink target="example_deleteExampleFeatureAppl">
> <auto-parameters-entity entity-name="ExampleFeatureAppl"/>
> <hyperlink/>
> </field>
> {quote}
> or
> {quote}
> <form name="ListExampleFeatureAppls" type="list" default-entity-name="ExampleFeatureAppl">
> <field name="deleteLink">
> <hyperlink target="example_deleteExampleFeatureAppl">
> <auto-parameters-entity/>
> <hyperlink/>
> </field>
> {quote}
> This method is inspired from auto-fields-entity and I homogenized on widget renderer screen (link), menu (link) and form (hyperlink, sub-link)
> Any comments are welcome
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira